Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0] Bump 6.0 workload #79085

Merged
merged 1 commit into from
Dec 6, 2022
Merged

Conversation

lewing
Copy link
Member

@lewing lewing commented Dec 1, 2022

Bump the 6.0.x version to 6.0.13 for servicing. Without this the 7.0.1xx sdks will not get the latest 6.0.13 runtimes for maui/wasm

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost assigned lewing Dec 1, 2022
@lewing lewing added this to the 7.0.x milestone Dec 1, 2022
@lewing lewing requested a review from radical December 1, 2022 21:12
@@ -7,7 +7,7 @@
<MinorVersion>0</MinorVersion>
<PatchVersion>2</PatchVersion>
<SdkBandVersion>7.0.100</SdkBandVersion>
<PackageVersionNet6>6.0.12</PackageVersionNet6>
<PackageVersionNet6>6.0.13</PackageVersionNet6>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This value should probably be calculated off of the .NET 7 version, rather than manually updated.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it needs to match the sdk downlevel version but we don't get the sdk update.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But since we almost always ship 6 and 7 in the same month., we can calculate '13' off of the 7.0.2 version in msbuild math logic.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, that is definitely better than it getting missed

@mmitche mmitche merged commit 8ac3832 into dotnet:release/7.0 Dec 6, 2022
@lewing lewing deleted the bump-6.0-workload branch December 6, 2022 18:21
@ghost ghost locked as resolved and limited conversation to collaborators Jan 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants