[.NET 7] Fix spurious OOMs after upgrading to 7 #79158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t#77478) Problem was that a BGC was in progress when the full GC was requested by setting the last_gc_before_oom flag, and at the end of the BGC we turned off the last_gc_before_oom flag. Fix is simply not to turn off the flag in the case of BGC.
… 1 GC. (dotnet#78973) This is a refinement suggested by Maoni for earlier PR#77478 - the last_gc_before_oom flag should also not be reset by an intervening gen 1 GC. This was noticed by Maoni due to a customer issue with spurious OOM exceptions with .NET Core 7.
|
Tagging subscribers to this area: @dotnet/gc Issue Detailsnull
|
cshung
approved these changes
Dec 3, 2022
|
Looks good to me. |
PeterSolMS
approved these changes
Dec 9, 2022
mangod9
changed the title
|
@mangod9 if you haven't yet done so, please send the email to Tactics, and add the |
jeffschwMSFT
approved these changes
Jan 4, 2023
rbhanda
added
Servicing-approved
|
Approved by Tactics (7.0.3). |
|
Was this fix included in 7.0.2 release ? |
|
It missed the window for 7.0.2, will be included in 7.0.3 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is fixing the issue (#78959) where customers are noticing spurious OOMs within their applications after upgrading to 7.
This is porting two PRs into 7:
#77478
#78973
Problem was that a BGC was in progress when the full GC was requested by setting the last_gc_before_oom flag, and at the end of the BGC we turned off the last_gc_before_oom flag.
Fix is simply not to turn off the flag in the case of BGC. This is a slightly incomplete fix hence the next PR (#78973) was required
Customer Impact
Reported by multiple customers where they are noticing OOMs after upgrading to .NET 7. Two customers have tried the private fix and confirmed it fixes the issue.
Regression
This is a regression from the 6.0.x version since the bug exists in Regions code.
Testing
Validated by at least two customers who had reported the issue.