Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ProductVersionSuffix to workload manifest names #79184

Closed
wants to merge 2 commits into from

Conversation

steveisok
Copy link
Member

This change adds a prerelease label to workload manifests so that they can sit beside official ones in the dotnet sdk. For example, Microsoft.NET.Workload.Mono.ToolChain.net7.Manifest-8.0.100-alpha.1 could install alongside Microsoft.NET.Workload.Mono.ToolChain.net7.Manifest-8.0.100 and not cause conflicts.

Fixes #79086

This change adds a prerelease label to workload manifests so that they can sit beside official ones in the dotnet sdk. For example, `Microsoft.NET.Workload.Mono.ToolChain.net7.Manifest-8.0.100-alpha.1` could install beside `Microsoft.NET.Workload.Mono.ToolChain.net7.Manifest-8.0.100`.

Fixes dotnet#79086
@ghost
Copy link

ghost commented Dec 3, 2022

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

This change adds a prerelease label to workload manifests so that they can sit beside official ones in the dotnet sdk. For example, Microsoft.NET.Workload.Mono.ToolChain.net7.Manifest-8.0.100-alpha.1 could install alongside Microsoft.NET.Workload.Mono.ToolChain.net7.Manifest-8.0.100 and not cause conflicts.

Fixes #79086

Author: steveisok
Assignees: -
Labels:

area-Infrastructure-mono

Milestone: -

@radical
Copy link
Member

radical commented Dec 3, 2022

https://github.com/steveisok/runtime/blob/ef16a86d343e15c6ac67c5bb3eef47ff9fc1db68/eng/testing/tests.wasm.targets#L337-L338
and
https://github.com/steveisok/runtime/blob/ef16a86d343e15c6ac67c5bb3eef47ff9fc1db68/eng/testing/workloads-testing.targets#L209-L212

.. need to depend on GetProductVersions.

With this, it fails to find Emscripten manifest for that SdkBandVersion (8.0.100-dev or 8.0.100-ci):

error NU1101: Unable to find package Microsoft.NET.Workload.Emscripten.net7.Manifest-8.0.100-dev.

What is the intended behavior here w.r.t the sdk band used for any dependency manifests?

@steveisok
Copy link
Member Author

https://github.com/steveisok/runtime/blob/ef16a86d343e15c6ac67c5bb3eef47ff9fc1db68/eng/testing/tests.wasm.targets#L337-L338 and https://github.com/steveisok/runtime/blob/ef16a86d343e15c6ac67c5bb3eef47ff9fc1db68/eng/testing/workloads-testing.targets#L209-L212

.. need to depend on GetProductVersions.

With this, it fails to find Emscripten manifest for that SdkBandVersion (8.0.100-dev or 8.0.100-ci):

error NU1101: Unable to find package Microsoft.NET.Workload.Emscripten.net7.Manifest-8.0.100-dev.

What is the intended behavior here w.r.t the sdk band used for any dependency manifests?

I'll try removing the target and see if we get what we expect. I was trying to match what the installer subset was doing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[workloads] Add prerelease version to workload manifest location
2 participants