Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix run.cmd syntax error #79250

Merged
merged 1 commit into from
Dec 6, 2022
Merged

Fix run.cmd syntax error #79250

merged 1 commit into from
Dec 6, 2022

Conversation

BruceForstall
Copy link
Member

No description provided.

@ghost ghost assigned BruceForstall Dec 5, 2022
@ghost
Copy link

ghost commented Dec 5, 2022

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: BruceForstall
Assignees: BruceForstall
Labels:

area-Infrastructure-coreclr
Milestone: -

jakobbotsch
jakobbotsch approved these changes Dec 5, 2022
View reviewed changes
Copy link
Member

@jakobbotsch jakobbotsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'm curious, do you know why this seemingly works ok for me/CI? How did you find the error?

@BruceForstall
Copy link
Member Author

I don't think CI uses run.cmd. Also, CMD spits a warning out on the console, but doesn't fail. I just noticed it when I saw that error when running run.cmd locally.

@BruceForstall BruceForstall merged commit c6e0b06 into dotnet:main Dec 6, 2022
@BruceForstall BruceForstall deleted the FixCmdSyntax branch December 6, 2022 02:59
@ghost ghost locked as resolved and limited conversation to collaborators Jan 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jakobbotsch jakobbotsch jakobbotsch approved these changes

Assignees

@BruceForstall BruceForstall

Labels
area-Infrastructure-coreclr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BruceForstall @jakobbotsch