improve SslStream exception after disposal #79329
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #78586,
CloseInternal
(e.g. Disose) can set_nestedRead
to 1 and then we can throw misleading exception on next Read(Async). There are some checks in place but this seems to be race condition - I was not able to write reliable functional test for it.This change basically splits the value so we can reliably determine when it was set by disposal.
Note that repro provided by @mikeharder still fails occasionally. That means that either
HttpClient
orAzure.Core.Pipeline
does concurrent reads and that is not permitted bySslStream
.Investigating that is separate from the misleading exception.
closes #32577