Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit tail. prefix to a tailcall test #79532

Merged
merged 1 commit into from
Dec 12, 2022

Conversation

jakobbotsch
Copy link
Member

Otherwise any change can cause us to stop tailcalling conservatively, e.g. due to new inlining introducing an address-taken local.

Fix #79517

Otherwise any change can cause us to stop tailcalling conservatively,
e.g. due to new inlining introducing an address-taken local.

Fix dotnet#79517
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Dec 12, 2022
@ghost ghost assigned jakobbotsch Dec 12, 2022
@ghost
Copy link

ghost commented Dec 12, 2022

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Otherwise any change can cause us to stop tailcalling conservatively, e.g. due to new inlining introducing an address-taken local.

Fix #79517

Author: jakobbotsch
Assignees: -
Labels:

area-CodeGen-coreclr

Milestone: -

@jakobbotsch jakobbotsch merged commit 84d58ec into dotnet:main Dec 12, 2022
@jakobbotsch jakobbotsch deleted the fix-79517 branch December 12, 2022 17:00
@ghost ghost locked as resolved and limited conversation to collaborators Jan 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failure JIT\\opt\\Tailcall\\TailcallVerifyWithPrefix\\TailcallVerifyWithPrefix.cmd
2 participants