Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Fix SslStream.IsMutuallyAuthenticated #79601

Merged

Conversation

simonrozsival
Copy link
Member

This is a follow-up of #79128. This PR updates the implementation of the CertificateValidationPal.IsLocalCertificateUsed function to work correctly on Android.

Fixes #65563
/cc @wfurt

@ghost
Copy link

ghost commented Dec 13, 2022

Tagging subscribers to 'arch-android': @steveisok, @akoeplinger
See info in area-owners.md if you want to be subscribed.

Issue Details

This is a follow-up of #79128. This PR updates the implementation of the CertificateValidationPal.IsLocalCertificateUsed function to work correctly on Android.

Fixes #65563
/cc @wfurt

Author: simonrozsival
Assignees: -
Labels:

area-System.Net.Security, os-android

Milestone: -

@simonrozsival
Copy link
Member Author

/azp run runtime-android

@ghost ghost assigned simonrozsival Dec 13, 2022
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@simonrozsival
Copy link
Member Author

/azp run runtime-android

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks.

@simonrozsival simonrozsival merged commit e49d7ec into dotnet:main Dec 16, 2022
@simonrozsival simonrozsival deleted the android-ssl-is-local-certificate-used branch December 16, 2022 12:29
@ghost ghost locked as resolved and limited conversation to collaborators Jan 15, 2023
@karelz karelz added this to the 8.0.0 milestone Mar 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SslStream.IsMutuallyAuthenticated returns wrong value when cached creds are used
3 participants