Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0] Make DacValidateMD more resilient to invalid MethodDesc #79862

Merged
merged 1 commit into from
Jan 5, 2023

Commits on Dec 20, 2022

  1. Make DacValidateMD more resilient to invalid MethodDesc

    The DacValidateMD is not resilient to invalid MethodDesc that contains
    NULL in its m_pMethTab field. It was found when using the ClrMD in the
    BenchmarkDotNet disassembler code which is trying to find if some constants
    in the code represent MethodDesc so that it can dump the related method
    name.
    
    This change fixes it by checking the MethodTable after it is extracted
    from the MethodDesc. There are two values that are not translated between
    the target and the debugger sides - NULL and -1. So I have added handling
    both as invalid there.
    janvorli authored and github-actions committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    99a6d6b View commit details
    Browse the repository at this point in the history