TarReader should dispose underlying stream if leaveOpen is false #79899
Conversation
|
should this be backported? |
* Dispose underlying stream in TarReader.DisposeAsync() as well Same as #79899 * Consolidate duplicated WrappedStream test helpers to Common sources * Dispose stream passed to WrappedStream
| { | ||
| foreach (Stream s in _dataStreamsToDispose) | ||
| _archiveStream.Dispose(); |
There was a problem hiding this comment.
What's the relationship between the streams in _dataStreamsToDispose and _archiveStream? Do the former streams wrap the latter? I'm wondering if the archive stream should actually be disposed of after rather than before the _dataStreamsToDispose.
There was a problem hiding this comment.
The code change is correct incorrect: The archive stream represents the whole tar archive, while the data streams represent sub-sections of the archive, each wrapping only the data section of an individual entry.
This means that all the individual data streams need to get disposed first, and the archive stream needs to be disposed at the end.
Edit: I see my mistake, I misread the diff.
There was a problem hiding this comment.
This means that all the individual data streams need to get disposed first, and the archive stream needs to be disposed at the end.
This is the opposite of what I did here. @carlossanlop shall we fix it?
…#79920) * Dispose underlying stream in TarReader.DisposeAsync() as well Same as dotnet#79899 * Consolidate duplicated WrappedStream test helpers to Common sources * Dispose stream passed to WrappedStream
… is false (#80598) * TarReader should dispose underlying stream if leaveOpen is false (#79899) * Dispose underlying stream in TarReader.DisposeAsync() as well (#79920) * Dispose underlying stream in TarReader.DisposeAsync() as well Same as #79899 * Consolidate duplicated WrappedStream test helpers to Common sources * Dispose stream passed to WrappedStream * Dispose archive stream after the list of DataStreams (#80572) * Dispose archive stream after the list of DataStreams * Add tests for TarReader.DisposeAsync properly disposing underlying stream Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
ghost
locked as resolved and limited conversation to collaborators
Potentially fixes #77012.