Add a test for IndexOfAnyValues.GetValues #80038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-system-memory Issue Details
|
Closed
danmoseley
reviewed
Dec 29, 2022
| @@ -13,6 +15,59 @@ namespace System.SpanTests | |||
| { | |||
| public static partial class SpanTests | |||
| { | |||
| private static readonly Func<IndexOfAnyValues<byte>, byte[]> s_getValuesByteMethod = | |||
There was a problem hiding this comment.
i guess you're intentionally getting it from IndexOfAnyValues<T> rather than IndexOfAnyValuesInRange<T>, as future refactorings might introduce new subclasses that also should work.
There was a problem hiding this comment.
Oh, never mind I mis-grepped. But this made me notice you're missing "" to exercise IndexOfEmptyValues.
There was a problem hiding this comment.
Added the case for empty values as well
danmoseley
approved these changes
Dec 29, 2022
MihaZupan
commented
Dec 29, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetValuesis only used by the debug view so we had no test coverage of it.