[release/7.0] Fixing compressed singlefile scenario on osx-arm64 #80283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Tagging subscribers to this area: @agocke, @vitek-karas, @VSadov Issue DetailsBackport of #79894 to release/7.0 /cc @VSadov Customer ImpactTestingRiskIMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
janvorli
approved these changes
Jan 6, 2023
jeffschwMSFT
approved these changes
Jan 6, 2023
jeffschwMSFT
added
Servicing-approved
|
Approved by Tactics (7.0.3). |
|
The Mono crossaot leg seems to be stuck. I'll merge the PR. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #79894 to release/7.0
/cc @VSadov
Customer Impact
When a user creates an app that uses both singlefile and compression and targets osx-arm64, the app cannot run.
Testing
Manual testing of the scenario. Also ran related tests, which this change fixes as well.
Risk
Low. This is a small change.
The root cause was not setting
MEM_RESERVE_EXECUTABLEflag for the memory allocated to decompress R2R assemblies.Since this is on osx-arm64 we need to play by the W^X rules. It is not possible to make writeable memory executable later on osx-arm64, if it does not have this flag when allocated.