Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get entry assembly name from host for GetProcessInfo2 command during suspension #80301

Merged
merged 4 commits into from
Jan 12, 2023

Conversation

elinor-fung
Copy link
Member

@elinor-fung elinor-fung commented Jan 6, 2023

  • Host runtime contract returns entry assembly name based on managed
    app being run, empty string for non-app (component) scenarios
  • ProcessInfo2 command falls back to querying for entry assembly name
    from host

The added tests target the host and diagnostics/runtime separately, since the diagnostics tests don't use the product host. The host tests check that the host runtime contract returns the expected values. The diagnostics tests check that the ProcessInfo2 command can get the entry assembly name during suspension assuming the host (corerun in the tests) returns the expected value.

Resolves #56808

- Host runtime contract returns entry assembly name based on managed
  app being run, empty string for non-app (component) scenarios
- ProcessInfo2 command falls back to querying for entry assembly name
  from host
@ghost
Copy link

ghost commented Jan 6, 2023

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Host runtime contract returns entry assembly name based on managed
    app being run, empty string for non-app (component) scenarios
  • ProcessInfo2 command falls back to querying for entry assembly name
    from host

The added tests target the host and diagnostics/runtime separately, since the diagnostics tests don't use the product host. The host tests check that the host runtime contract returns the expected values. The diagnostics tests check that the ProcessInfo2 command can get the entry assembly name during suspension assuming the host (corerun in the tests) returns the expected value.

Author: elinor-fung
Assignees: elinor-fung
Labels:

area-Host

Milestone: -

@elinor-fung elinor-fung changed the title Enable getting entry assembly name from host Get entry assembly name from host for GetProcessInfo2 command during suspension Jan 6, 2023
Copy link
Member

@vitek-karas vitek-karas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the one comment this looks good.

src/coreclr/hosts/corerun/corerun.cpp Outdated Show resolved Hide resolved
@ghost
Copy link

ghost commented Jan 6, 2023

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Host runtime contract returns entry assembly name based on managed
    app being run, empty string for non-app (component) scenarios
  • ProcessInfo2 command falls back to querying for entry assembly name
    from host

The added tests target the host and diagnostics/runtime separately, since the diagnostics tests don't use the product host. The host tests check that the host runtime contract returns the expected values. The diagnostics tests check that the ProcessInfo2 command can get the entry assembly name during suspension assuming the host (corerun in the tests) returns the expected value.

Resolves #56808

Author: elinor-fung
Assignees: elinor-fung
Labels:

area-Diagnostics-coreclr

Milestone: -

Copy link
Member

@davmason davmason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@elinor-fung elinor-fung merged commit 59649c3 into dotnet:main Jan 12, 2023
@elinor-fung elinor-fung deleted the entryAssemblyNameFromHost branch January 12, 2023 15:06
@ghost ghost locked as resolved and limited conversation to collaborators Feb 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting managed assembly entrypoint on diagnostic pipe GetProcessInfo2 command during suspension
3 participants