-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get entry assembly name from host for GetProcessInfo2 command during suspension #80301
Get entry assembly name from host for GetProcessInfo2 command during suspension #80301
Conversation
- Host runtime contract returns entry assembly name based on managed app being run, empty string for non-app (component) scenarios - ProcessInfo2 command falls back to querying for entry assembly name from host
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov Issue Details
The added tests target the host and diagnostics/runtime separately, since the diagnostics tests don't use the product host. The host tests check that the host runtime contract returns the expected values. The diagnostics tests check that the ProcessInfo2 command can get the entry assembly name during suspension assuming the host (corerun in the tests) returns the expected value.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the one comment this looks good.
Tagging subscribers to this area: @tommcdon Issue Details
The added tests target the host and diagnostics/runtime separately, since the diagnostics tests don't use the product host. The host tests check that the host runtime contract returns the expected values. The diagnostics tests check that the ProcessInfo2 command can get the entry assembly name during suspension assuming the host (corerun in the tests) returns the expected value. Resolves #56808
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
app being run, empty string for non-app (component) scenarios
from host
The added tests target the host and diagnostics/runtime separately, since the diagnostics tests don't use the product host. The host tests check that the host runtime contract returns the expected values. The diagnostics tests check that the ProcessInfo2 command can get the entry assembly name during suspension assuming the host (corerun in the tests) returns the expected value.
Resolves #56808