Fix timeout in regex source generated test #80459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Tagging subscribers to this area: @dotnet/area-system-text-regularexpressions Issue DetailsThe test is using Roslyn to dynamically emit a Regex with the source generator, as we do throughout the test suite. However, this test is about validating the default static regex timeout, and the Roslyn code itself uses a regex. To work around this, this PR splits off the source generated test into its own dedicated one that doesn't rely on Roslyn. Fixes #77814
|
The test is using Roslyn to dynamically emit a Regex with the source generator, as we do throughout the test suite. However, this test is about validating the default static regex timeout, and the Roslyn code itself uses a regex. To work around this, this PR splits off the source generated test into its own dedicated one that doesn't rely on Roslyn.
stephentoub
force-pushed
the
fixregextimeout
branch
from
101fe3c to
a6537e4
Compare
danmoseley
approved these changes
Jan 11, 2023
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test is using Roslyn to dynamically emit a Regex with the source generator, as we do throughout the test suite. However, this test is about validating the default static regex timeout, and the Roslyn code itself uses a regex. To work around this, this PR splits off the source generated test into its own dedicated one that doesn't rely on Roslyn.
Fixes #77814