[release/7.0] Invalidate buffered data when bypassing the cache #80503
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Tagging subscribers to this area: @dotnet/area-system-io Issue DetailsBackport of #80432 to release/7.0 /cc @adamsitnik Customer ImpactTestingRiskIMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
|
@adamsitnik please fill out the template describing how this affected customers and how the fix addressed it. When ready, please send an email to Tactics requesting approval, and add the The Code Complete cut-off date has been moved to Fri Jan 13th since next weekend is a long weekend (Monday is a holiday in the US). So we want to try to merge all backports before Friday EOD to monitor the base branch for any unexpected breaks. |
leecow
added
Servicing-approved
|
Approved by Tactics (7.0.3). |
ghost
locked as resolved and limited conversation to collaborators
Backport of #80432 to release/7.0
Customer Impact
Customers who are using
FileStream.ReadAsyncwith buffering enabled (the default) might read incorrect data. It's a silent error, but the "good thing" about this bug is that it's really hard to reproduce (a very specific sequence of reads and backward seeks need to be performed).Testing
Automated tests were added, and they are passing. Additional local validation against repro provided by the customer has confirmed that the bug is gone.
Risk
Very low, the change simply invalidates the cache at the right time.
No OOB changes needed for System.IO.FileSystem or System.Private.CoreLib.