-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for exercising certificates with platform provider keys #80558
Conversation
Tagging subscribers to this area: @dotnet/area-system-security, @vcsjones Issue DetailsWith #77801, #77809, and #80457, we can now correctly issue and use an Let's add a test that does and end-to-end test and then I think we can close it. Closes #75971
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you @vcsjones !
src/libraries/System.Security.Cryptography/tests/X509Certificates/CertTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Security.Cryptography/tests/X509Certificates/CertTests.cs
Outdated
Show resolved
Hide resolved
/azp list |
/azp run runtime-libraries-coreclr outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
68c1e69
to
354cbd9
Compare
/azp run runtime-libraries-coreclr outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for the additional refactoring!
The failures are unrelated, merging. |
With #77801, #77809, and #80457, we can now correctly issue and use an
X509Certificate2
with a key backed by a Platform Provider TPM key, both for RSA and ECDSA.Let's add a test that does and end-to-end test and then I think we can close it.
Closes #75971