Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for exercising certificates with platform provider keys #80558

Merged
merged 4 commits into from
Jan 16, 2023

Conversation

vcsjones
Copy link
Member

With #77801, #77809, and #80457, we can now correctly issue and use an X509Certificate2 with a key backed by a Platform Provider TPM key, both for RSA and ECDSA.

Let's add a test that does and end-to-end test and then I think we can close it.

Closes #75971

@ghost
Copy link

ghost commented Jan 12, 2023

Tagging subscribers to this area: @dotnet/area-system-security, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

With #77801, #77809, and #80457, we can now correctly issue and use an X509Certificate2 with a key backed by a Platform Provider TPM key, both for RSA and ECDSA.

Let's add a test that does and end-to-end test and then I think we can close it.

Closes #75971

Author: vcsjones
Assignees: -
Labels:

area-System.Security

Milestone: -

Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @vcsjones !

@adamsitnik
Copy link
Member

/azp list

@azure-pipelines
Copy link

CI/CD Pipelines for this repository:

@adamsitnik
Copy link
Member

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vcsjones vcsjones force-pushed the test-certs-with-tpm-key branch from 68c1e69 to 354cbd9 Compare January 13, 2023 22:42
@vcsjones
Copy link
Member Author

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the additional refactoring!

@adamsitnik
Copy link
Member

The failures are unrelated, merging.

@adamsitnik adamsitnik merged commit a879885 into dotnet:main Jan 16, 2023
@vcsjones vcsjones deleted the test-certs-with-tpm-key branch January 17, 2023 17:43
@ghost ghost locked as resolved and limited conversation to collaborators Feb 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue in ECDsaCertificateExtensions.CopyWithPrivateKey with TPM
3 participants