[browser][http] Fix blocking of streaming response and abort #80693
Conversation
- return bytes of streaming response as soon as available
pavelsavara
added
arch-wasm
|
Tagging subscribers to 'arch-wasm': @lewing |
pavelsavara
changed the title
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@hakenr, would you please have time to test it ? |
|
@pavelsavara Yes, I'm happy to test it, I just don't know how to get the new version into my own project. Yes, I'm happy to test it, I just don't know how to get the new version into my own project. Can you please direct me where I can find some instructions? |
I will have to figure it out. My naive attempt to use net8 runtime in net7 blazor project didn't work. There are NodeJS CI failures which I need to handle first. Will ping you again, thanks! |
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/backport to release/7.0 |
|
Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3960939369 |
|
@pavelsavara backporting to release/7.0 failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: - fix unhandled error in reader.cancel() promise
Applying: free reader
Applying: fix + test
Applying: test
Applying: test
Applying: feedback
Applying: new test for streaming abort
error: sha1 information is lacking or useless (src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.cs).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0007 new test for streaming abort
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
|
@pavelsavara an error occurred while backporting to release/7.0, please check the run log for details! Error: git am failed, most likely due to a merge conflict. |
…80693) - return bytes of streaming response as soon as available - fix unhandled error in reader.cancel() promise - return cancelable promise from http_wasm_get_streamed_response_bytes - unit test for slowly streamed chunks - unit test for streaming and default cancellation
- return bytes of streaming response as soon as available - fix unhandled error in reader.cancel() promise - return cancelable promise from http_wasm_get_streamed_response_bytes - unit test for slowly streamed chunks - unit test for streaming and default cancellation
- return bytes of streaming response as soon as available - fix unhandled error in reader.cancel() promise - return cancelable promise from http_wasm_get_streamed_response_bytes - unit test for slowly streamed chunks - unit test for streaming and default cancellation
ghost
locked as resolved and limited conversation to collaborators
http_wasm_get_streamed_response_bytesFixes #79238
Fixes #80696
Should be merged back to Net7