Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0] [Android] Add error code to the assert error message #80701

Merged
merged 1 commit into from
Feb 8, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jan 16, 2023

Backport of #80423 to release/7.0

/cc @simonrozsival

Customer Impact

There is a report of a crash when JNI AttachCurrentThreadAsDaemon method is called (#79395). The logs don't contain any relevant information so it's hard to diagnose the root of the problem. This PR adds the error code returned from AttachCurrentThreadAsDaemon to make diagnosing the error easier.

Testing

Automatic tests in CI.

Risk

Low

@ghost
Copy link

ghost commented Jan 16, 2023

Tagging subscribers to this area: @dotnet/area-system-security, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #80423 to release/7.0

/cc @simonrozsival

Customer Impact

Testing

Risk

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-System.Security

Milestone: -

@simonrozsival simonrozsival added this to the 7.0.x milestone Jan 16, 2023
@simonrozsival simonrozsival added the Servicing-consider Issue for next servicing release review label Jan 16, 2023
@simonrozsival simonrozsival self-assigned this Jan 17, 2023
@rbhanda rbhanda modified the milestones: 7.0.x, 7.0.5 Jan 17, 2023
@rbhanda rbhanda added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Jan 17, 2023
@carlossanlop
Copy link
Member

carlossanlop commented Feb 8, 2023

Approved by Tactics for 7.0.4.
Signed off by area owner.
No OOB changes needed for this PR.
CI failures unrelated.
Ready to merge. :shipit:

@carlossanlop carlossanlop merged commit 997c3ae into release/7.0 Feb 8, 2023
@carlossanlop carlossanlop deleted the backport/pr-80423-to-release/7.0 branch February 8, 2023 22:16
@carlossanlop carlossanlop modified the milestones: 7.0.5, 7.0.4 Feb 8, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Mar 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Security Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants