Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow forced building of mobile manifest pkgs, outside mobile builds #80920

Merged
merged 1 commit into from
Jan 25, 2023
Merged

Allow forced building of mobile manifest pkgs, outside mobile builds #80920

merged 1 commit into from
Jan 25, 2023

Conversation

directhex
Copy link
Contributor

We may need to build our manifests separately from our mobile packages, this change allows us to force the build

@directhex directhex requested a review from steveisok January 20, 2023 14:34
@ghost ghost assigned directhex Jan 20, 2023
@ghost
Copy link

ghost commented Jan 20, 2023

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

We may need to build our manifests separately from our mobile packages, this change allows us to force the build

Author: directhex
Assignees: -
Labels:

area-Infrastructure-mono
Milestone: -

@steveisok steveisok requested a review from lewing January 20, 2023 17:19
@steveisok
Copy link
Member

@lewing this is geared towards allowing source build to build the manifests (and only the manifests) on linux.

@directhex directhex merged commit 51a36ff into dotnet:main Jan 25, 2023
@directhex directhex mentioned this pull request Jan 25, 2023
Closed
5 tasks
@directhex directhex mentioned this pull request Feb 3, 2023
Merged
directhex added a commit that referenced this pull request Feb 6, 2023
@directhex
Split Mono manifest creation into a separate subset (#81598)
5487473 
* Split manifest building from mono-packages.proj into a standalone subset, in order to fix up #80920 so building manifests works when the runtime is CoreCLR (as is typically the case on source-build)
steveisok pushed a commit that referenced this pull request Feb 7, 2023
@github-actions @directhex
[release/8.0-preview1] Split Mono manifest creation into a separate s…
9f654ef 
…ubset (#81719)

Backport of #81598

Fix up #80920 so building manifests works when the runtime is CoreCLR (as is typically the case on source-build)

Co-authored-by: Jo Shields <directhex@apebox.org>
@ghost ghost locked as resolved and limited conversation to collaborators Feb 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lewing lewing lewing approved these changes

@steveisok steveisok steveisok approved these changes

@marek-safar marek-safar Awaiting requested review from marek-safar

Assignees

@directhex directhex

Labels
area-Infrastructure-mono
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@directhex @steveisok @lewing