Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0] [wasm] Fix analyzer support in templates #81077

Merged
merged 1 commit into from
Feb 8, 2023

Conversation

maraf
Copy link
Member

@maraf maraf commented Jan 24, 2023

Simplified backport of #77704
Closes #79314

Customer Impact

Fixes warning produced by the supported platform analyzer on apps generated from wasm templates (browser, console).

Testing

Manual
Build the workload in repo
Replace changed files
Create apps from modified templates
Build the apps using workload in repo

Risk

None

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

- Apply SupportedOSPlatformAttribute in templates.
@maraf maraf added arch-wasm WebAssembly architecture area-Build-mono labels Jan 24, 2023
@maraf maraf added this to the 7.0.x milestone Jan 24, 2023
@maraf maraf self-assigned this Jan 24, 2023
@ghost
Copy link

ghost commented Jan 24, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Simplified backport of #77704

Author: maraf
Assignees: maraf
Labels:

arch-wasm, area-Build-mono

Milestone: 7.0.x

@maraf maraf marked this pull request as ready for review January 24, 2023 11:46
@maraf maraf added the Servicing-consider Issue for next servicing release review label Jan 25, 2023
@maraf
Copy link
Member Author

maraf commented Jan 25, 2023

Failure is not related.

@rbhanda rbhanda added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Jan 26, 2023
@rbhanda rbhanda modified the milestones: 7.0.x, 7.0.4 Jan 26, 2023
@carlossanlop
Copy link
Member

Approved by Tactics for 7.0.4.
Signed-off by area owners.
No OOB changes needed for this PR.
CI failure is #81544
Ready to merge. :shipit:

@carlossanlop carlossanlop merged commit 0a9c99f into dotnet:release/7.0 Feb 8, 2023
@maraf maraf deleted the WasmUnsupportedPlatform70 branch February 9, 2023 11:23
@ghost ghost locked as resolved and limited conversation to collaborators Mar 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Build-mono Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants