[release/7.0] Fix filtered exceptions when checking for ip forwarding #81157
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsBackport of #76383 to release/7.0 /cc @rzikm Customer ImpactTestingRiskIMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
|
Test failure seems unrelated. (Microsoft.VisualBasic.Core.Tests) |
|
@ElanHasson Would you be able to test the fix in your repro? The process is:
|
|
@ElanHasson any chance to try if it really fixes the problem in your specific environment? |
rbhanda
added
Servicing-approved
|
Approved by Tactics for 7.0.4. @karelz @rzikm @wfurt would you like us to wait for @ElanHasson 's confirmation before I merge this? |
|
I think it is OK to merge @carlossanlop . The fix is pretty small so let's assume it will work as expected. It is best interest of @ElanHasson to still do the validation and let us know if it does not for some reason. |
|
@ElanHasson it would be really, really useful for next servicing release if you could check it works in next ~24 hours. Do you think it is possible? |
|
Argh! Accidental misclick on Close PR, sorry! ;( |
|
@karelz Yep! It's deploying shortly |
|
@karelz @rzikm @wfurt @wfurt @carlossanlop Thanks! This works on my end in same gVisor environment that had the issue when I reported. Thank you! |
carlossanlop
force-pushed
the
backport/pr-76383-to-release/7.0
branch
from
9b70d1f
to
dc23afb
Compare
ghost
locked as resolved and limited conversation to collaborators
Closes #81061, #75883.
Backport of #76383 to release/7.0
/cc @rzikm
Customer Impact
Regression in 7.0 from 6.0 breaks customers who need to query IP forwarding details on some constrained systems where IP forwarding information is not available (the appropriate file
/proc/sys/net/ipv(4|6)/conf/{interface}/forwardingdoes not exist).A specific example would be Orleans users running in gVisor - see #81061 for more details.
It will also help WSL1 (which is not officially supported) - see #75883.
Testing
Manual testing in WSL1 environment. The affected method no longer throws the exception.
Risk
Low. The change is small and there have been no related problems observed in main (8.0) after merging PR #76383 on 2022/9/30.