Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable the /JIT/opt/ObjectStackAllocation/ObjectStackAllocationTests #81195

Merged
merged 2 commits into from
Jan 26, 2023

Conversation

janvorli
Copy link
Member

Disable the test until a dotnet with a fix of the issue #81103 is used in the runtime repo to build / run tests.

Disable the test until a dotnet with a fix of the issue dotnet#81103 is used
in the runtime repo to build / run tests.
@janvorli janvorli requested a review from AndyAyersMS January 25, 2023 23:09
@janvorli janvorli self-assigned this Jan 25, 2023
@ghost
Copy link

ghost commented Jan 25, 2023

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

Issue Details

Disable the test until a dotnet with a fix of the issue #81103 is used in the runtime repo to build / run tests.

Author: janvorli
Assignees: janvorli
Labels:

area-Meta

Milestone: -

@janvorli
Copy link
Member Author

/azp run coreclr-runtime outerloop

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

Copy link
Member

@AndyAyersMS AndyAyersMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with a blanket disable, as long as we think we'll update the crossgen2 host fairly soon.

Otherwise, it seems like this should be placed in the crossgen-specific set of excludes a bit further down in the file.

@janvorli
Copy link
Member Author

Ah, I've missed that there is a crossgen specific section, let me move it there.

@janvorli
Copy link
Member Author

/azp run coreclr-runtime outerloop

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@am11
Copy link
Member

am11 commented Jan 26, 2023

@janvorli, were outerloop tests failing without this suppression after the fix? I'm asking because tests use live build of crossgen2.

@janvorli
Copy link
Member Author

@am11 are you saying that in the CI runs this test uses live build of runtime for the crossgen2? In my local test runs, it was using the runtime from the .dotnet folder, so I've assumed it was the same in the CI.

@am11
Copy link
Member

am11 commented Jan 26, 2023

Ah, I thought the failure was in crossgen2 itself. Yes we use dotnet from the sdk with crossgen2.dll from live build. Looks good to me, thanks!

@janvorli janvorli merged commit f3bebb9 into dotnet:main Jan 26, 2023
@janvorli janvorli deleted the disable-objectstackallocation-tests branch January 26, 2023 19:41
@ghost ghost locked as resolved and limited conversation to collaborators Feb 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants