-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable the /JIT/opt/ObjectStackAllocation/ObjectStackAllocationTests #81195
Disable the /JIT/opt/ObjectStackAllocation/ObjectStackAllocationTests #81195
Conversation
Disable the test until a dotnet with a fix of the issue dotnet#81103 is used in the runtime repo to build / run tests.
Tagging subscribers to this area: @dotnet/area-meta Issue DetailsDisable the test until a dotnet with a fix of the issue #81103 is used in the runtime repo to build / run tests.
|
/azp run coreclr-runtime outerloop |
No pipelines are associated with this pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with a blanket disable, as long as we think we'll update the crossgen2 host fairly soon.
Otherwise, it seems like this should be placed in the crossgen-specific set of excludes a bit further down in the file.
Ah, I've missed that there is a crossgen specific section, let me move it there. |
/azp run coreclr-runtime outerloop |
No pipelines are associated with this pull request. |
@janvorli, were outerloop tests failing without this suppression after the fix? I'm asking because tests use live build of crossgen2. |
@am11 are you saying that in the CI runs this test uses live build of runtime for the crossgen2? In my local test runs, it was using the runtime from the |
Ah, I thought the failure was in crossgen2 itself. Yes we use |
Disable the test until a dotnet with a fix of the issue #81103 is used in the runtime repo to build / run tests.