[release/7.0] Unpin the C# compiler version #81247
Conversation
Unpin the C# compiler and build our shipping Roslyn components against the released Roslyn components for 7.0.100 instead of against pre-release builds. Also rename the MicrosoftCodeAnalysisVersion_4_X property now that it's pinned to Roslyn 4.4 forever. Fixes dotnet#65317
jkoritzinsky
added
Servicing-consider
ghost
assigned
jkoritzinsky
changed the title
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsFixes Issue #65317 DescriptionUnpin the C# compiler and build our shipping Roslyn components against the released Roslyn components for 7.0.100 instead of against pre-release builds. Also rename the MicrosoftCodeAnalysisVersion_4_X property now that it's pinned to Roslyn 4.4 forever. Customer ImpactThis is an infrastructure PR to ensure we can pick up servicing fixes from the compiler easily and build against release bits. RegressionN/A TestingRiskMinimal risk Package authoring signed off?Package authoring reviewers tagged. IMPORTANT: If this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
There was a problem hiding this comment.
approved. we can follow the tell mode process.
Is this blocking?
Adding @carlossanlop to help with when we can merge.
|
As mentioned offline, this is not blocking. This is infrastructure cleanup. The issue was marked as "blocking-servicing" to ensure we wouldn't lose it in our list of issues and would address it quickly after 7.0 was released. |
...crosoft.Extensions.Logging.Abstractions/src/Microsoft.Extensions.Logging.Abstractions.csproj
Outdated
Show resolved
Hide resolved
...crosoft.Extensions.Logging.Abstractions/src/Microsoft.Extensions.Logging.Abstractions.csproj
Outdated
Show resolved
Hide resolved
jeffschwMSFT
removed
the
Servicing-consider
Fixes Issue #65317
Description
Unpin the C# compiler and build our shipping Roslyn components against the released Roslyn components for 7.0.100 instead of against pre-release builds.
Also rename the MicrosoftCodeAnalysisVersion_4_X property now that it's pinned to Roslyn 4.4 forever.
Customer Impact
This is an infrastructure PR to ensure we can pick up servicing fixes from the compiler easily and build against release bits.
Regression
N/A
Testing
Risk
Minimal risk
Package authoring signed off?
Package authoring reviewers tagged.
IMPORTANT: If this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.