Unify type instantiations in reflection emit #81518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-system-reflection Issue DetailsThis change is suggested during code review of #78544
|
|
On mono, the layout of these types is visible to the runtime, so it would be better to make them a partial type, and create .Mono.cs versions of them. This is how runtime specific types are usually handled. |
5 tasks
marek-safar
reviewed
Feb 2, 2023
...libraries/System.Private.CoreLib/src/System/Reflection/Emit/XyzOnTypeBuilderInstantiation.cs
Outdated
Show resolved
Hide resolved
src/mono/System.Private.CoreLib/src/System/Reflection/Emit/TypeBuilderInstantiation.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Feb 2, 2023
src/libraries/System.Private.CoreLib/src/System.Private.CoreLib.Shared.projitems
Outdated
Show resolved
Hide resolved
buyaa-n
force-pushed
the
unify-type-inst
branch
2 times, most recently
from
59e761b to
9c298c2
Compare
jkotas
reviewed
Feb 3, 2023
...braries/System.Private.CoreLib/src/System/Reflection/Emit/FieldOnTypeBuilderInstantiation.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Feb 3, 2023
...braries/System.Private.CoreLib/src/System/Reflection/Emit/FieldOnTypeBuilderInstantiation.cs
Outdated
Show resolved
Hide resolved
buyaa-n
force-pushed
the
unify-type-inst
branch
from
9c298c2 to
ebb30d3
Compare
buyaa-n
force-pushed
the
unify-type-inst
branch
from
ebb30d3 to
e83db73
Compare
jkotas
reviewed
Feb 6, 2023
src/libraries/System.Private.CoreLib/src/System/Reflection/Emit/TypeBuilderInstantiation.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Feb 6, 2023
...raries/System.Private.CoreLib/src/System/Reflection/Emit/MethodOnTypeBuilderInstantiation.cs
Outdated
Show resolved
Hide resolved
buyaa-n
force-pushed
the
unify-type-inst
branch
from
6b0e129 to
4b93524
Compare
buyaa-n
commented
Feb 8, 2023
src/mono/System.Private.CoreLib/src/System/Reflection/Emit/DerivedTypes.Mono.cs
Show resolved
Hide resolved
vargaz
reviewed
Feb 11, 2023
src/libraries/System.Private.CoreLib/src/System/Reflection/Emit/SymbolType.cs
Show resolved
Hide resolved
buyaa-n
requested review from
vargaz,
jkotas,
steveharter and
AaronRobinsonMSFT
...raries/System.Private.CoreLib/src/System/Reflection/Emit/MethodOnTypeBuilderInstantiation.cs
Outdated
Show resolved
Hide resolved
...raries/System.Private.CoreLib/src/System/Reflection/Emit/MethodOnTypeBuilderInstantiation.cs
Show resolved
Hide resolved
...raries/System.Private.CoreLib/src/System/Reflection/Emit/MethodOnTypeBuilderInstantiation.cs
Outdated
Show resolved
Hide resolved
...s/System.Private.CoreLib/src/System/Reflection/Emit/ConstructorOnTypeBuilderInstantiation.cs
Outdated
Show resolved
Hide resolved
...braries/System.Private.CoreLib/src/System/Reflection/Emit/FieldOnTypeBuilderInstantiation.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Feb 15, 2023
src/libraries/System.Private.CoreLib/src/System/Reflection/Emit/TypeBuilderInstantiation.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/Reflection/MethodBase.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/Reflection/Emit/TypeBuilderInstantiation.cs
Outdated
Show resolved
Hide resolved
steveharter
reviewed
Feb 16, 2023
src/mono/System.Private.CoreLib/src/System/Reflection/Emit/RuntimeTypeBuilder.Mono.cs
Show resolved
Hide resolved
jkotas
reviewed
Feb 16, 2023
src/libraries/System.Private.CoreLib/src/System/Reflection/Emit/SymbolType.cs
Outdated
Show resolved
Hide resolved
4 tasks
This reverts commit 039b9f2.
jkotas
reviewed
Feb 17, 2023
buyaa-n
force-pushed
the
unify-type-inst
branch
from
442e38b to
26d3168
Compare
jkotas
reviewed
Feb 17, 2023
There was a problem hiding this comment.
CoreCLR changes LGTM. @vargaz @lambdageek Could you please review the Mono changes?
vargaz
reviewed
Feb 17, 2023
src/libraries/System.Private.CoreLib/src/System/Reflection/Emit/SymbolType.cs
Show resolved
Hide resolved
|
Mono changes look ok. |
lambdageek
approved these changes
Feb 17, 2023
buyaa-n
force-pushed
the
unify-type-inst
branch
from
98ea02a to
58b9331
Compare
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is suggested during code review of #78544