Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JIT: Expand runtime lookups in a late phase #81635

Merged
merged 71 commits into from
Mar 14, 2023
Merged

JIT: Expand runtime lookups in a late phase #81635

merged 71 commits into from
Mar 14, 2023

Commits on Feb 4, 2023

  1. Expand runtime lookups in a late phase

    @EgorBo
    EgorBo committed Feb 4, 2023
    Configuration menu
    Copy the full SHA
    2dcd5e4 View commit details
    Browse the repository at this point in the history

  2. Clean up

    @EgorBo
    EgorBo committed Feb 4, 2023
    Configuration menu
    Copy the full SHA
    2c7a4a3 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2023

  1. Merge branch 'main' of github.com:dotnet/runtime into expand-runtime-… 

    …lookups-later
    @EgorBo
    EgorBo committed Feb 5, 2023
    Configuration menu
    Copy the full SHA
    5754331 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2023

  1. test

    @EgorBo
    EgorBo committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    dca8140 View commit details
    Browse the repository at this point in the history

  2. test2

    @EgorBo
    EgorBo committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    e303869 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2023

  1. Merge branch 'main' of github.com:dotnet/runtime into expand-runtime-… 

    …lookups-later
    @EgorBo
    EgorBo committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    aa760e5 View commit details
    Browse the repository at this point in the history

  2. Test

    @EgorBo
    EgorBo committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    20e79dc View commit details
    Browse the repository at this point in the history

  3. Enable JitDasmWithAlignmentBoundaries in Release

    @EgorBo
    EgorBo committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    22f34a1 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' of github.com:dotnet/runtime into expand-runtime-… 

    …lookups-later
    @EgorBo
    EgorBo committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    c3681c1 View commit details
    Browse the repository at this point in the history

  5. clean up

    @EgorBo
    EgorBo committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    2110ec0 View commit details
    Browse the repository at this point in the history

  6. Revert "Enable JitDasmWithAlignmentBoundaries in Release" 

    This reverts commit 22f34a1.
    @EgorBo
    EgorBo committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    54b224c View commit details
    Browse the repository at this point in the history

  7. add hashtable

    @EgorBo
    EgorBo committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    e4d4944 View commit details
    Browse the repository at this point in the history

  8. test

    @EgorBo
    EgorBo committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    3e272e0 View commit details
    Browse the repository at this point in the history

  9. Initial version (no dynamic expansion for now)

    @EgorBo
    EgorBo committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    2671e14 View commit details
    Browse the repository at this point in the history

  10. Clean up

    @EgorBo
    EgorBo committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    64ae149 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2023

  1. Clean up

    @EgorBo
    EgorBo committed Feb 26, 2023
    Configuration menu
    Copy the full SHA
    d991533 View commit details
    Browse the repository at this point in the history

  2. Test

    @EgorBo
    EgorBo committed Feb 26, 2023
    Configuration menu
    Copy the full SHA
    e20dd2d View commit details
    Browse the repository at this point in the history

  3. Update BB flags properly

    @EgorBo
    EgorBo committed Feb 26, 2023
    Configuration menu
    Copy the full SHA
    8fc0374 View commit details
    Browse the repository at this point in the history

  4. Add dynamic expansion path

    @EgorBo
    EgorBo committed Feb 26, 2023
    Configuration menu
    Copy the full SHA
    269cb36 View commit details
    Browse the repository at this point in the history

  5. Add dynamic expansion

    @EgorBo
    EgorBo committed Feb 26, 2023
    Configuration menu
    Copy the full SHA
    3c1cb1c View commit details
    Browse the repository at this point in the history

  6. Add comments

    @EgorBo
    EgorBo committed Feb 26, 2023
    Configuration menu
    Copy the full SHA
    47524ed View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2023

  1. Merge branch 'main' of github.com:dotnet/runtime into expand-runtime-… 

    …lookups-later
    @EgorBo
    EgorBo committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    05ae42d View commit details
    Browse the repository at this point in the history

  2. test

    @EgorBo
    EgorBo committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    ba8fdc2 View commit details
    Browse the repository at this point in the history

  3. test dotnet#2

    @EgorBo
    EgorBo committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    5d6cf4a View commit details
    Browse the repository at this point in the history

  4. it should be <=

    @EgorBo
    EgorBo committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    ec00f5b View commit details
    Browse the repository at this point in the history

  5. Update flowgraph.cpp

    @EgorBo
    EgorBo committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    ec893da View commit details
    Browse the repository at this point in the history

  6. test 3

    @EgorBo
    EgorBo committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    f81882f View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2023

  1. test 4

    @EgorBo
    EgorBo committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    d1d0bc8 View commit details
    Browse the repository at this point in the history

  2. test 4

    @EgorBo
    EgorBo committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    eea468a View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2023

  1. Merge branch 'main' of github.com:dotnet/runtime into expand-runtime-… 

    …lookups-later
    @EgorBo
    EgorBo committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    3d5d61a View commit details
    Browse the repository at this point in the history

  2. Test 5

    @EgorBo
    EgorBo committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    9af1079 View commit details
    Browse the repository at this point in the history

  3. Clean up

    @EgorBo
    EgorBo committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    ea3bf76 View commit details
    Browse the repository at this point in the history

  4. Found it!

    @EgorBo
    EgorBo committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    8a2a8ad View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2023

  1. fix assert

    @EgorBo
    EgorBo committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    777def6 View commit details
    Browse the repository at this point in the history

  2. fix assert

    @EgorBo
    EgorBo committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    b18b12e View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' of github.com:dotnet/runtime into expand-runtime-… 

    …lookups-later
    @EgorBo
    EgorBo committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    0f7fc3d View commit details
    Browse the repository at this point in the history

  4. move to separate file + fix some diff regressions

    @EgorBo
    EgorBo committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    5eee49b View commit details
    Browse the repository at this point in the history

  5. Clean up, address some of the feedback

    @EgorBo
    EgorBo committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    2ff3799 View commit details
    Browse the repository at this point in the history

  6. Address feedback [WIP]

    @EgorBo
    EgorBo committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    11cac11 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2023

  1. Implement gtSplitTree

    @jakobbotsch
    jakobbotsch committed Mar 4, 2023
    Configuration menu
    Copy the full SHA
    936c7d2 View commit details
    Browse the repository at this point in the history

  2. Test

    @EgorBo
    EgorBo committed Mar 4, 2023
    Configuration menu
    Copy the full SHA
    a982e68 View commit details
    Browse the repository at this point in the history

  3. fix Release

    @EgorBo
    EgorBo committed Mar 4, 2023
    Configuration menu
    Copy the full SHA
    aad1188 View commit details
    Browse the repository at this point in the history

  4. Fix assert

    @EgorBo
    EgorBo committed Mar 4, 2023
    Configuration menu
    Copy the full SHA
    f3853a7 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2023

  1. Initial clean up

    @EgorBo
    EgorBo committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    f2d22fe View commit details
    Browse the repository at this point in the history

  2. Mark ArrayStack ctor explicit

    @jakobbotsch
    jakobbotsch committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    3e3b15f View commit details
    Browse the repository at this point in the history

  3. Add docs to gtSplitTree

    @jakobbotsch
    jakobbotsch committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    0f40259 View commit details
    Browse the repository at this point in the history

  4. Fix up ASG(COMMA(...), ...) handling

    @jakobbotsch
    jakobbotsch committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    2a29ac3 View commit details
    Browse the repository at this point in the history

  5. Split out uses in execution order instead

    @jakobbotsch
    jakobbotsch committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    598ff71 View commit details
    Browse the repository at this point in the history

  6. Remove dead local

    @jakobbotsch
    jakobbotsch committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    733fcd9 View commit details
    Browse the repository at this point in the history

  7. Clean up

    @EgorBo
    EgorBo committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    a62a135 View commit details
    Browse the repository at this point in the history

  8. Avoid creating statements for non address-exposed locals

    @jakobbotsch
    jakobbotsch committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    730ed35 View commit details
    Browse the repository at this point in the history

  9. More cleanup (use callUse)

    @EgorBo
    EgorBo committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    9c6c89f View commit details
    Browse the repository at this point in the history

  10. use old path for tier0 (slightly better CQ/TP for tier0)

    @EgorBo
    EgorBo committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    f2c1508 View commit details
    Browse the repository at this point in the history

  11. Code clean up

    @EgorBo
    EgorBo committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    c1cc980 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2023

  1. Merge branch 'main' of github.com:dotnet/runtime into expand-runtime-… 

    …lookups-later

# Conflicts:
#	src/coreclr/jit/compiler.cpp
#	src/coreclr/jit/compiler.h
#	src/coreclr/jit/compphases.h
#	src/coreclr/jit/gentree.cpp
    @EgorBo
    EgorBo committed Mar 11, 2023
    Configuration menu
    Copy the full SHA
    6f587df View commit details
    Browse the repository at this point in the history

  2. resolve conflicts

    @EgorBo
    EgorBo committed Mar 11, 2023
    Configuration menu
    Copy the full SHA
    2834318 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2023

  1. Update runtimelookup.cpp

    @EgorBo
    EgorBo committed Mar 12, 2023
    Configuration menu
    Copy the full SHA
    79b5076 View commit details
    Browse the repository at this point in the history

  2. Update src/coreclr/jit/runtimelookup.cpp 

    Co-authored-by: Jakob Botsch Nielsen <Jakob.botsch.nielsen@gmail.com>
    @EgorBo @jakobbotsch
    EgorBo and jakobbotsch committed Mar 12, 2023
    Configuration menu
    Copy the full SHA
    f0f14a7 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2023

  1. Merge branch 'main' of github.com:dotnet/runtime into expand-runtime-… 

    …lookups-later
    @EgorBo
    EgorBo committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    6061fa7 View commit details
    Browse the repository at this point in the history

  2. Mitigate some tier0 regressions

    @EgorBo
    EgorBo committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    2a3d83b View commit details
    Browse the repository at this point in the history

  3. clone fastpath for tier0

    @EgorBo
    EgorBo committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    07cf9e7 View commit details
    Browse the repository at this point in the history

  4. Remove redundant impSpillSideEffects

    @EgorBo
    EgorBo committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    3a3f4ca View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2023

  1. test

    @EgorBo
    EgorBo committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    8af93a9 View commit details
    Browse the repository at this point in the history

  2. Fix regressions

    @EgorBo
    EgorBo committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    afe2dd4 View commit details
    Browse the repository at this point in the history

  3. fix tp regressions

    @EgorBo
    EgorBo committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    7909435 View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review 

    Co-authored-by: Jakob Botsch Nielsen <Jakob.botsch.nielsen@gmail.com>
    @EgorBo @jakobbotsch
    EgorBo and jakobbotsch committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    258cbae View commit details
    Browse the repository at this point in the history

  5. Address feedback

    @EgorBo
    EgorBo committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    1afb6f8 View commit details
    Browse the repository at this point in the history

  6. Add goto SCAN_BLOCK_AGAIN

    @EgorBo
    EgorBo committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    a116695 View commit details
    Browse the repository at this point in the history

  7. Update src/coreclr/jit/runtimelookup.cpp 

    Co-authored-by: Jakob Botsch Nielsen <Jakob.botsch.nielsen@gmail.com>
    @EgorBo @jakobbotsch
    EgorBo and jakobbotsch committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    386446e View commit details
    Browse the repository at this point in the history

  8. Address feedback

    @EgorBo
    EgorBo committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    d2f3fec View commit details
    Browse the repository at this point in the history

  9. update side effects for fallbackBb

    @EgorBo
    EgorBo committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    19034d9 View commit details
    Browse the repository at this point in the history