Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a missing assert in constraint resolver #81641

Merged
merged 1 commit into from
Feb 12, 2023

Conversation

am11
Copy link
Member

@am11 am11 commented Feb 4, 2023

In other case (few lines below), we have this assert before assigning this nullable ptr a value.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Feb 4, 2023
@am11
Copy link
Member Author

am11 commented Feb 4, 2023

cc @trylek, this assert makes SVM with contravariant issue (#78621) a bit more clear.

command:

$ CORE_ROOT=$(pwd)/artifacts/bin/testhost/net8.0-osx-Debug-arm64/shared/Microsoft.NETCore.App/8.0.0 \
    artifacts/bin/testhost/net8.0-osx-Debug-arm64/shared/Microsoft.NETCore.App/8.0.0/corerun \
    ../svm-contravariance/bin/Debug/net8.0/svm-contravariance.dll

before:

zsh: segmentation fault  CORE_ROOT=  ../svm-contravariance/bin/Debug/net8.0/svm-contravariance.dll

after:

Assert failure(PID 58618 [0x0000e4fa], Thread: 29822069 [0x1c70c75]): pfForceUseRuntimeLookup != NULL
    File: /Users/am11/projects/runtime/src/coreclr/vm/methodtable.cpp Line: 8515
    Image: /Users/am11/projects/runtime/artifacts/bin/testhost/net8.0-osx-Debug-arm64/shared/Microsoft.NETCore.App/8.0.0/corerun

zsh: abort      CORE_ROOT=  ../svm-contravariance/bin/Debug/net8.0/svm-contravariance.dll

@am11 am11 requested a review from jkotas February 12, 2023 02:27
@jkotas jkotas merged commit 77b5016 into dotnet:main Feb 12, 2023
@am11 am11 deleted the feature/typesystem-coreclr/null-check branch February 12, 2023 03:15
@ghost ghost locked as resolved and limited conversation to collaborators Mar 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-VM-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants