-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/7.0] fix TLS resume with client certificates on Linux #81795
Conversation
Tagging subscribers to this area: @dotnet/ncl, @vcsjones Issue Detailspartial backport of #79898 Customer Impactbecause of the TLS resume, customer can see unexpected dependencies and incorrect behavior when using client certificates on Linux. The TLS cache in in process memory so the impact is limited. TestingNew tests were added to cover the scenarios. Regressionyes, new in 7.0 Risk LowWe did not do TLS resume at all prior 7.0 on Linux. This change brings back the behavior in one more case we missed.
|
Tactics approval via email by @SteveMCarroll on Wed 2/8. |
@rzikm can you please help look at the test failures and link them to known issues? @carlossanlop will have easier time to merge it later. Thank you! |
Looks like we are clean on test results, so we should be ready to merge when suitable - @carlossanlop let us know if we missed anything. Thanks! |
Yes, aside from the warnings that appear in logging (example):
there is also a DL called "dncpartners" where this removal was communicated many weeks out from the actual removal. We've moved to Azure-based VMs, please use |
Approved by Tactics for 7.0.4. |
thanks everyone. |
partial backport of #79898
fixes #79869
Customer Impact
because of the TLS resume, customer can see unexpected dependencies and incorrect behavior when using client certificates on Linux. The TLS cache in in process memory so the impact is limited.
Testing
New tests were added to cover the scenarios.
The tests depend on
IsMutuallyAuthenticated
property that may be incorrect because of #65563.Since we do not port fix for that I made tests Linux specific for the release branch. (there is no resume on macOS)
(the tests added in main also discover gaps so the product change #79898 had more fixes for Window)
Regression
yes, new in 7.0
Risk Low
We did not do TLS resume at all prior 7.0 on Linux. This change brings back the behavior in one more case we missed.