-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update alpine test images #81841
update alpine test images #81841
Conversation
Tagging subscribers to this area: @dotnet/ncl Issue DetailsPoC
|
"production" tags are not available yet but runs with new msquic look good to me:
and Alpine 3.17 with OpenSSL 3 and system crypto
cc: @dotnet/ncl @nibanks |
do you have any idea why this may be failing @tarekgh? I'm trying to add new image and and this seems to be close to localization...? If you do not know, who else should I ask? |
This is clearly the culture used to parse the number is not the same used formatting the number. '1,0' is using |
Looking more at the test, it looks like the test expect to run with the Console.WriteLine($"{CultureInfo.GetCultureInfo("fr-FR").NumberFormat.NumberDecimalSeparator}"); @wfurt is this something you can help checking? or share the image and I can try it. |
Localization issues resolved. Thanks @tarekgh. it is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks
Looks like this is not complete, there are now tons of failing tests on Alpine 3.14, see the edit in #81901 |
Contributes to #81901. (brings microsoft/msquic#3417)
3.17 has OpenSSL 3.