Fix major performance regression in legacy struct marshalling APIs #81941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds a simple cache for the marshalling stubs. This cache improves performance of the test mentioned in the issue by 20+x. Fixes dotnet#45100
jkoritzinsky
approved these changes
Feb 10, 2023
AaronRobinsonMSFT
approved these changes
Feb 10, 2023
Co-authored-by: Aaron Robinson <arobins@microsoft.com>
jkotas
commented
Feb 10, 2023
|
Will this fix be added to .NET 6 or do we have to wait for .NET8 ? |
|
I am sorry backporting the fix to .NET 6 would not meet the servicing bug bar. |
|
I thought it might be as its a regression and a major one. Will wait for .NET 8 then. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a simple cache for the marshalling stubs. This cache improves performance of the test mentioned in the issue by 20+x.
Fixes #45100