-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ConfigurationBinder usage from Console Logging #82098
Conversation
This allows ConfigurationBinder, and its dependencies like TypeConverter, to be trimmed in an application that uses Console Logging, like an ASP.NET API application. Fix dotnet#81931
Tagging subscribers to this area: @dotnet/area-extensions-logging Issue DetailsThis allows ConfigurationBinder, and its dependencies like TypeConverter, to be trimmed in an application that uses Console Logging, like an ASP.NET API application. Fix #81931
|
src/libraries/Microsoft.Extensions.Logging.Console/src/ConsoleLoggerConfigureOptions.cs
Outdated
Show resolved
Hide resolved
src/libraries/Microsoft.Extensions.Logging.Console/src/ConsoleFormatterConfigureOptions.cs
Outdated
Show resolved
Hide resolved
src/libraries/Microsoft.Extensions.Logging.Console/src/ConsoleFormatterConfigureOptions.cs
Show resolved
Hide resolved
...ing.Console/tests/Microsoft.Extensions.Logging.Console.Tests/ConsoleLoggerExtensionsTests.cs
Show resolved
Hide resolved
Changes LGTM. do we have tests when having invalid values inside the configuration? something when defining string with |
Overall LGTM. |
LGTM! |
@eerhardt would we just replace this with the Configuration Binder source generator generated code once that's ready? |
Yes, that is the goal/intention. See #81931 (comment). If/when the Configuration Binder source generator can support this library, we should switch to using it. Things that may be tricky:
|
This allows ConfigurationBinder, and its dependencies like TypeConverter, to be trimmed in an application that uses Console Logging, like an ASP.NET API application.
Fix #81931