Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/6.0] Install native dependencies on all Apple OS in CI #82322

Merged
merged 1 commit into from
Mar 8, 2023
Merged

[release/6.0] Install native dependencies on all Apple OS in CI #82322

merged 1 commit into from
Mar 8, 2023

Conversation

am11
Copy link
Member

@am11 am11 commented Feb 17, 2023

Backport of #82263.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Feb 17, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Feb 17, 2023
@ghost
Copy link

ghost commented Feb 17, 2023

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #82263.

Author: am11
Assignees: -
Labels:

area-Infrastructure, community-contribution, needs-area-label
Milestone: -

am11
am11 commented Feb 17, 2023
View reviewed changes
eng/install-native-dependencies.sh

if [ -z "$os" ]; then
. "$(dirname "$0")"/native/init-os-and-arch.sh
os="$(echo "$os" | tr "[:upper:]" "[:lower:]")"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is new; lowercase changes in 8.0 didn't require this transformation.

@am11 am11 force-pushed the feature/ci/native-deps branch from e94534f to d73cce3 Compare February 17, 2023 22:31
@am11 am11 changed the title Install native dependencies on all Apple OS in CI [release/6.0] Install native dependencies on all Apple OS in CI Feb 17, 2023
@am11 am11 removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Feb 17, 2023
@am11 am11 mentioned this pull request Feb 17, 2023
Merged
@am11 am11 force-pushed the feature/ci/native-deps branch from d73cce3 to 0ccb1f1 Compare February 17, 2023 23:37
@steveisok steveisok requested a review from a team February 18, 2023 00:35
@akoeplinger
Copy link
Member

actions/runner-images#7125 was merged which should add pkg-config back, it still needs to roll out as builds still fail as of right now. I'd be in favor of merging this but I'll let @carlossanlop decide.

@am11
Copy link
Member Author

am11 commented Feb 20, 2023

We run install-native-dependencies is some OSX legs, this PR is basically aligning it to run on all OSX legs with native build. The installation is idempotent; it only installs the missing dependencies. This step is taking 15-20 seconds.

@runfoapp runfoapp bot mentioned this pull request Feb 20, 2023
Closed
@akoeplinger akoeplinger mentioned this pull request Feb 21, 2023
Closed
@steveisok
Copy link
Member

@carlossanlop are you good with merging this?

@carlossanlop
Copy link
Member

Waiting for Matt's answer here: #82323 (comment)

@carlossanlop carlossanlop merged commit b4f44f7 into dotnet:release/6.0 Mar 8, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Apr 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@steveisok steveisok steveisok approved these changes

Assignees
No one assigned
Labels
area-Infrastructure community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@am11 @akoeplinger @steveisok @carlossanlop