Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unbalanced brackets in clrjit natvis GenTree output #82332

Merged

Conversation

BruceForstall
Copy link
Member

No description provided.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Feb 18, 2023
@ghost ghost assigned BruceForstall Feb 18, 2023
@ghost
Copy link

ghost commented Feb 18, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: BruceForstall
Assignees: -
Labels:

area-CodeGen-coreclr

Milestone: -

@BruceForstall
Copy link
Member Author

@kunalspathak PTAL
cc @dotnet/jit-contrib

@kunalspathak
Copy link
Member

I just noticed this, but changes LGTM. Wondering if you noticed anything in visualization that made you fix this? Lately, I am noticing GenTree are not rendered correctly. It always shows gtCSEnum field and we need to expand the node to see the visualization that we have in natvis file:

MicrosoftTeams-image (1)

After i expand, I see this. Ideally, we should see the red highlighted at the top:

MicrosoftTeams-image (2)

@ghost ghost locked as resolved and limited conversation to collaborators Mar 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants