Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GetHashCode implementation for InterproceduralState #82431

Merged
merged 1 commit into from
Feb 21, 2023

Conversation

vitek-karas
Copy link
Member

This is a port of dotnet/linker#3163 to runtime repo.

@vitek-karas vitek-karas added the area-Tools-ILLink .NET linker development as well as trimming analyzers label Feb 21, 2023
@vitek-karas vitek-karas self-assigned this Feb 21, 2023
@ghost ghost added the linkable-framework Issues associated with delivering a linker friendly framework label Feb 21, 2023
@ghost
Copy link

ghost commented Feb 21, 2023

Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas
See info in area-owners.md if you want to be subscribed.

Issue Details

This is a port of dotnet/linker#3163 to runtime repo.

Author: vitek-karas
Assignees: vitek-karas
Labels:

area-Tools-ILLink

Milestone: -

@vitek-karas
Copy link
Member Author

The test failed due to:
NuGet.Protocol.Core.Types.FatalProtocolException : Unable to load the service index for source https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet7/nuget/v3/index.json.
---- System.Net.Http.HttpRequestException : Response status code does not indicate success: 503 (Service Unavailable).

This is a known problem with the analyzer tests that they rely on live NuGet to get a ref package. The plan is to eventually copy the ref assemblies which the test was built with into the test output as assets and use those instead (so that the tests don't require to be online).

Unrelated to this change.

@vitek-karas vitek-karas merged commit 9507a9c into dotnet:main Feb 21, 2023
@vitek-karas vitek-karas deleted the FixGetHashCode branch February 21, 2023 19:27
@ghost ghost locked as resolved and limited conversation to collaborators Mar 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Tools-ILLink .NET linker development as well as trimming analyzers linkable-framework Issues associated with delivering a linker friendly framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants