Fix Icon(Stream) handling of partial reads #82621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Icon's ctor assumes Read on a stream will always produce as much data as was asked for, and that's not guaranteed to be the case.
|
Tagging subscribers to this area: @dotnet/area-system-drawing Issue DetailsIcon's ctor assumes Read on a stream will always produce as much data as was asked for, and that's not guaranteed to be the case. Fixes #80261
|
This was referenced Feb 24, 2023
tannergooding
approved these changes
Mar 2, 2023
carlossanlop
reviewed
Mar 2, 2023
| stream.Read(_iconData, 0, _iconData.Length); | ||
| #if NET7_0_OR_GREATER | ||
| stream.ReadExactly(_iconData); | ||
| #else |
There was a problem hiding this comment.
Do we want to backport this?
There was a problem hiding this comment.
I don't think so. It's been like this forever and to my knowledge no one has complained. I found it via an audit rather than feedback.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Icon's ctor assumes Read on a stream will always produce as much data as was asked for, and that's not guaranteed to be the case.
Fixes #80261