Do not use ALC name for AssemblyName

[buyaa-n]

DispatchProxy uses Reflection.Emit internally and used to use only one AssemblyBuilder for all proxy types.

In .NET 7 that fixed with #62095, now it creates a separate AssemblyBuilder, for each AssemblyLoadContext of the proxy type and also used the ALC name for creating AssemblyName

In some cases, ALC name could include a path:

runtime/src/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs

Line 273 in ccbcb7f

AssemblyLoadContext alc = new IndividualAssemblyLoadContext($"Assembly.LoadFile({normalizedPath})");

and special characters used for the path is not valid name for AssemblyName constructor and throws.

With this PR we are just using the same name for each ALC, we might want to pass the AssemblyLoadContext.Name as @KalleOlaviNiemitalo suggested for debugging purpose, but ALC info probably should be passed/solved appropriately with #62234 instead, or if needed we can update accordingly later.

See more details from #80387

[ghost]

Tagging subscribers to this area: @dotnet/area-system-reflection
See info in area-owners.md if you want to be subscribed.

Issue Details

---

DispatchProxy uses Reflection.Emit internally and used to use only one AssemblyBuilder for all proxy types.

In .NET 7 that fixed with #62095, now it creates a separate AssemblyBuilder, for each AssemblyLoadContext of the proxy type and also used the ALC name for creating AssemblyName

In some cases, ALC name could include a path:

runtime/src/libraries/System.Private.CoreLib/src/System/Reflection/Assembly.cs

Line 273 in ccbcb7f

AssemblyLoadContext alc = new IndividualAssemblyLoadContext($"Assembly.LoadFile({normalizedPath})");

and special characters used for the path is not valid name for AssemblyName constructor and throws.

With this PR we are just using the same name for each ALC, we might want to pass the AssemblyLoadContext.Name as @KalleOlaviNiemitalo suggested for debugging purpose, but ALC info probably should be passed/solved appropriately with #62234 instead, or if needed we can update accordingly later.

See more details from #80387

Author:	buyaa-n
Assignees:	buyaa-n
Labels:	area-System.Reflection
Milestone:	-

[AaronRobinsonMSFT]

@elinor-fung and @vitek-karas FYI

[buyaa-n]

The failure is unrelated and known

[buyaa-n]

/backport to release/7.0

[github-actions]

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/4295951511

[github-actions]

@buyaa-n backporting to release/7.0 failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Applying: Do not use ALC name for AssemblyName
Using index info to reconstruct a base tree...
M	src/libraries/System.Reflection.DispatchProxy/src/System/Reflection/DispatchProxyGenerator.cs
M	src/libraries/System.Reflection.DispatchProxy/tests/DispatchProxyTests.cs
Falling back to patching base and 3-way merge...
Auto-merging src/libraries/System.Reflection.DispatchProxy/tests/DispatchProxyTests.cs
CONFLICT (content): Merge conflict in src/libraries/System.Reflection.DispatchProxy/tests/DispatchProxyTests.cs
Auto-merging src/libraries/System.Reflection.DispatchProxy/src/System/Reflection/DispatchProxyGenerator.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Do not use ALC name for AssemblyName
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

[github-actions]

@buyaa-n an error occurred while backporting to release/7.0, please check the run log for details!

Error: git am failed, most likely due to a merge conflict.