-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try to untangle the rid calculation. #82832
Changes from all commits
9d890f4
c320ff9
494afb7
034d1d5
92ffb2f
ae67592
8c91698
4ce7c57
e5ec2a5
6d84cb4
802bd95
959f5be
44dcd0d
9c2a977
b16dc2d
220c624
b422a2f
edeb0f2
76b3e61
9c31e98
0d194d5
06bb0ea
6973d62
83baf6c
1eeef02
a361268
89a70f6
78bcd23
d672f14
bd52080
3e5800c
a29df93
0814de1
01bae0d
8a0f558
acb8cf5
81402ef
8219051
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -31,10 +31,11 @@ | |
<InnerBuildArgs>$(InnerBuildArgs) --nodereuse false</InnerBuildArgs> | ||
<InnerBuildArgs>$(InnerBuildArgs) --warnAsError false</InnerBuildArgs> | ||
<InnerBuildArgs>$(InnerBuildArgs) --outputrid $(TargetRid)</InnerBuildArgs> | ||
<!-- RuntimeOS is the build host rid OS. --> | ||
<InnerBuildArgs>$(InnerBuildArgs) /p:RuntimeOS=$(RuntimeOS)</InnerBuildArgs> | ||
<!-- PackageOS and ToolsOS control the rids of prebuilts consumed by the build. | ||
They are set to RuntimeOS so they match with the build SDK rid. --> | ||
<InnerBuildArgs Condition="'$(RuntimeOS)' != ''">$(InnerBuildArgs) /p:PackageOS=$(RuntimeOS) /p:ToolsOS=$(RuntimeOS)</InnerBuildArgs> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Who provides RuntimeOS in source build? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is that still the right property to set or do we want to change that? |
||
<!-- BaseOS is an expected known rid in the graph that TargetRid is compatible with. | ||
It's used to add TargetRid in the graph if the parent can't be detected. --> | ||
It's used to add TargetRid in the graph if the parent can't be detected. --> | ||
<InnerBuildArgs>$(InnerBuildArgs) /p:AdditionalRuntimeIdentifierParent=$(BaseOS)</InnerBuildArgs> | ||
<InnerBuildArgs Condition="'$(OfficialBuildId)' != ''">$(InnerBuildArgs) /p:OfficialBuildId=$(OfficialBuildId)</InnerBuildArgs> | ||
<InnerBuildArgs Condition="'$(ContinuousIntegrationBuild)' != ''">$(InnerBuildArgs) /p:ContinuousIntegrationBuild=$(ContinuousIntegrationBuild)</InnerBuildArgs> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Would be good to move this up in a follow-up and add TargetsMobile into the group as well.