Add NT_SIGINFO NOTE to ELF dumps #83059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linux Watson needs this to better triage ELF dumps. Add CreateDumpOptions helper struct to pass all the command options around. Add the "--code", "--errno", "--address" command line options used to fill the NT_SIGINFO NOTE. The runtime passes to createdump on a crash. Added "ExceptionType" field to "Parameters" section of the Linux crash report json.
|
Tagging subscribers to this area: @tommcdon Issue DetailsCustomer ImpactLinux Watson needs this to better triage ELF dumps. 1st party teams have asked for this. Add CreateDumpOptions helper struct to pass all the command options around. Add the "--code", "--errno", "--address" command line options used to fill the NT_SIGINFO NOTE. The runtime passes to createdump on a crash. Added "ExceptionType" field to "Parameters" section of the Linux crash report json. TestingAll the SOS diagnostics tests pass with these changes. RiskLow. Createdump/core generation only.
|
jeffschwMSFT
approved these changes
Mar 7, 2023
rbhanda
added
Servicing-approved
hoyosjs
approved these changes
Mar 8, 2023
|
Approved by Tactics. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Customer Impact
Linux Watson needs this to better triage ELF dumps. 1st party teams have asked for this.
Issue: #40958
This change update createdump which allows windbg/Watson to determine which thread actually crashed (via the .lastevent command). The NT_SIGINFO record has been missing from Linux core dumps causing the wrong thread (startup thread) to be blamed for the crash. This breaks Watson bucketing.
The underlying issue here that we do not put enough data in Linux coredumps: The “crashing thread” isn’t marked as the one of interest. Without this information, the debugger assumes that the 0th thread (usually the startup thread) is the guilty party.
When an automated debugging service comes along, like Watson/!analyze, they cannot properly triage the bug. Instead of properly blaming the correct thread (with the correct exception), it will try to blame the non-crashing “crashing thread” (usually just the main function doing nothing, sitting in a wait call). In effect, this renders all of our Azure Watson bucketing for all of our partner teams and customers useless.
Added "ExceptionType" field to "Parameters" section of the Linux crash report json.
Testing
All the SOS diagnostics tests pass with these changes.
Risk
Low. Createdump/core generation only.