[release/7.0] Add more type-forwarders for Xamarin.Android compatibility to mscorlib.dll and System.Drawing.Common.dll #83137
Conversation
…b.dll (dotnet#82618) The legacy Xamarin.Android version of mscorlib.dll differed a bit compared to the .NET Framework mscorlib.dll, mostly because of additions for .NET Standard 2.1 support. This meant that an assembly which was compiled against that mscorlib expects types there but since we didn't have type-forwarders in our mscorlib.dll shim to point them to the right assembly you'd get a TypeLoadException when running on modern .NET 6 Android. Fixes dotnet#82193 (cherry picked from commit d8203e7)
…ng.Common.dll (dotnet#82839) The legacy Xamarin.Android version of System.Drawing.Common.dll contained these types, add forwarders so we don't get a TypeLoadException when using an assembly compiled against that in modern .NET Android. Fixes dotnet#82829 (cherry picked from commit e486f38)
akoeplinger
added
Servicing-consider
ghost
assigned 
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsBackport of #82618 and #82839 to release/7.0 Customer ImpactThe legacy Xamarin.Android versions of mscorlib.dll and System.Drawing.Common.dll differed a bit compared to the .NET Framework versions, mostly because of additions for .NET Standard 2.1 support. This meant that an assembly which was compiled against those assemblies (e.g. from a nuget package which targets Fixes #82193 and #82829 TestingManual testing with nuget packages from the customer. RiskLow, we're only adding a few additional type-forwarders.
|
|
@akoeplinger I noticed you added the servicing-consider label, even though it's marked as an infra issue. If it was intended to consider this ask-mode, can you please send the Tactics email requesting their approval? |
|
@carlossanlop I just picked this label because it seemed the most fitting, I'll follow up on the tactics approval. |
rbhanda
added
Servicing-approved
|
No OOB changes needed for System.Drawing.Common. |
Backport of #82618 and #82839 to release/7.0
Customer Impact
The legacy Xamarin.Android versions of mscorlib.dll and System.Drawing.Common.dll differed a bit compared to the .NET Framework versions, mostly because of additions for .NET Standard 2.1 support.
This meant that an assembly which was compiled against those assemblies (e.g. from a nuget package which targets
monoandroidTFM) expects types there but since we didn't have type-forwarders in our mscorlib.dll/System.Drawing.Common.dll shims to point them to the right assembly you'd get a TypeLoadException when running on modern .NET 7 Android.Fixes #82193 and #82829
Also fixes these MAUI issues: dotnet/maui#5142, dotnet/maui#5078, dotnet/maui#3903
Testing
Manual testing with nuget packages from the customer.
Risk
Low, we're only adding a few additional type-forwarders.