-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dependencies.props import #833
Merged
janvorli
merged 5 commits into
dotnet:master
from
ViktorHofer:FixDependeciesPropsImport
Dec 19, 2019
Merged
Fix dependencies.props import #833
janvorli
merged 5 commits into
dotnet:master
from
ViktorHofer:FixDependeciesPropsImport
Dec 19, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janvorli
reviewed
Dec 13, 2019
@@ -16,7 +16,7 @@ set "__ProjectDir=%~dp0" | |||
:: remove trailing slash | |||
if %__ProjectDir:~-1%==\ set "__ProjectDir=%__ProjectDir:~0,-1%" | |||
set "__ProjectFilesDir=%__ProjectDir%" | |||
set "__RootBinDir=%__ProjectDir%\..\..\..\artifacts" | |||
set "__RootBinDir=%~dp0..\..\..\artifacts" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A nit - maybe use __ThisScriptDir
instead of %~dp0
here and in the change below.
ViktorHofer
force-pushed
the
FixDependeciesPropsImport
branch
from
December 16, 2019 15:40
dc4ae4e
to
5c8cabc
Compare
I force-pushed to resolve the conflicts without changing anything. |
janvorli
approved these changes
Dec 19, 2019
trylek
added a commit
to trylek/runtime
that referenced
this pull request
Dec 22, 2019
This reverts commit bd27324. This is one of the four commits in the time range between the last passing runtime-coreclr run and the first run after which all runs have been failing on Windows ARM / ARM64. Thanks Tomas
ghost
locked as resolved and limited conversation to collaborators
Dec 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All this logic should be cleaned-up anyway but this is a minimal change to unblock local dev workflows.