Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add references to xunit.*.dll to CLRTest.Crossgen.targets #83413

Merged
merged 1 commit into from
Mar 14, 2023

Commits on Mar 14, 2023

  1. Add references to xunit.*.dll to CLRTest.Crossgen.targets

    This change fixes the exceptions thrown from Crossgen2 JIT
    interface when JIT tries to resolve tokens from xunit.assert.
    As a secondary effect the frequent exception throws triggered
    the race condition
    
    dotnet#81884
    
    triggering non-deterministic native CoreCLR runtime failures on
    arm64. I was originally reluctant to fix this primary issue until
    the native runtime bug is understood as otherwise this fix would
    just cause the issue to stop manifesting without being actually
    fixed. As the runtime bug has been fixed by now, I am fixing
    Crossgen2 executions to stop hitting these resolution exceptions.
    
    Thanks
    
    Tomas
    trylek committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    b7ddbbe View commit details
    Browse the repository at this point in the history