Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] Do not run embuilder minimal build #83475

Merged
merged 13 commits into from
Mar 23, 2023

Conversation

radekdoulik
Copy link
Member

@radekdoulik radekdoulik commented Mar 15, 2023

emsdk has now the the cache primed dotnet/emsdk#315, so we don't need to run embuilder minimal build in WasmApp.Native.targets anymore. That avoids writing into cache, which is located in installed nuget and can be read only.

@ghost ghost assigned radekdoulik Mar 15, 2023
@radekdoulik radekdoulik added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Mar 15, 2023
@radekdoulik radekdoulik removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Mar 17, 2023
@radekdoulik radekdoulik marked this pull request as ready for review March 17, 2023 11:25
@radekdoulik
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radekdoulik
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lewing
Copy link
Member

lewing commented Mar 17, 2023

Is the cache prepopulated in the helix images too?

@radekdoulik
Copy link
Member Author

Is the cache prepopulated in the helix images too?

Good point, dotnet/dotnet-buildtools-prereqs-docker#826

@radekdoulik
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radekdoulik
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radekdoulik
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Pull request contains merge conflicts.

@radekdoulik
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radekdoulik
Copy link
Member Author

Lets try to use the default cache for AOT tests again.

One of the tests timeouted in the last build. Probably the first one to build.

  system_libs:INFO: compiled 21 inputs
  cache:INFO:  - ok
  cache:INFO: generating system asset: symbol_lists/f071237d11694561702b3c0c06c6cd2d1359efbc.txt... (this will be cached in "C:\Users\ContainerAdministrator\.emscripten-cache\symbol_lists\f071237d11694561702b3c0c06c6cd2d1359efbc.txt" for subsequent builds)
  cache:INFO: generating system asset: sysroot\lib\wasm32-emscripten\struct_info.json... (this will be cached in "C:\Users\ContainerAdministrator\.emscripten-cache\sysroot\lib\wasm32-emscripten\struct_info.json" for subsequent builds)
...
[17:16:55] info: Starting:    System.Net.WebSockets.Client.Tests.dll
[17:16:55] warn: WARNING: Web browsers do not support closing the output side of a WebSocket. CloseOutputAsync has closed the socket and discarded any incoming messages.
[17:16:56] fail: [out of order message from the browser]: http://127.0.0.1:49224/dotnet.js 2 WebSocket connection to 'ws://127.0.0.1:49224/WebSocket/EchoWebSocket.ashx?subprotocol=CustomProtocol' failed: Error during WebSocket handshake: Response must not include 'Sec-WebSocket-Protocol' header if not present in request: CustomProtocol
[17:16:56] fail: [out of order message from the browser]: http://127.0.0.1:49224/dotnet.js 2 WebSocket connection to 'wss://127.0.0.1:49225/WebSocket/EchoWebSocket.ashx?subprotocol=CustomProtocol' failed: Error during WebSocket handshake: Response must not include 'Sec-WebSocket-Protocol' header if not present in request: CustomProtocol
[17:16:56] fail: [out of order message from the browser]: http://127.0.0.1:49224/dotnet.js 2 WebSocket connection to 'ws://127.0.0.1:49275/' failed: Connection closed before receiving a handshake response
[17:16:58] fail: [out of order message from the browser]: http://127.0.0.1:49224/dotnet.js 2 WebSocket connection to 'ws://278ce290cae04b17bd9de225189217d6/' failed: Error in connection establishment: net::ERR_NAME_NOT_RESOLVED
[17:46:52] fail: Tests timed out. Killing driver service pid 3916
[17:46:52] fail: Application has finished with exit code TIMED_OUT but 0 was expected
XHarness exit code: 71 (GENERAL_FAILURE)

@radekdoulik
Copy link
Member Author

The fails are unrelated

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants