[Mono] Intrinsify As* on ARM64 with mini JIT on ARM64 #83544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanyang-mono
requested review from
vargaz,
lambdageek and
SamMonoRT
as code owners
This was referenced Mar 16, 2023
vargaz
reviewed
Mar 17, 2023
|
LGTM otherwise. |
| @@ -3665,6 +3665,8 @@ mono_arch_output_basic_block (MonoCompile *cfg, MonoBasicBlock *bb) | |||
| } | |||
| break; | |||
| } | |||
| case OP_XCAST: | |||
There was a problem hiding this comment.
It's worth noting that As isn't really a regular cast. It's a reinterpretation of bits and in RyuJIT there is no node created for it. It's purely an API to satisfy the higher level type systems and for the JIT we completely elide it in importation to guarantee it is zero cost.
|
CI failures are not related to this PR. |
vargaz
approved these changes
Mar 17, 2023
|
CI failures are not related to this PR. |
fanyang-mono
changed the title
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #80566
Intrinsify
Vector128.As*on ARM64 with mini JIT.