-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ConvertIcuTimeFormatString: convert narrow no-break spaces to spaces too. #83589
Conversation
Tagging subscribers to this area: @dotnet/area-system-globalization Issue DetailsFixes #83571. @stephentoub ptal.
|
we are discussing the right fix on the issue #83571 |
@tarekgh I've updated the implementation. Can you take a look? |
@tmds the change looks good to me, Thanks. We need to add tests especially parsing date/time strings including several types of spaces. You may look at the file
|
@tmds did you have a chance to address the remaining feedback on this PR? Thanks! |
@tarekgh I've added a test. ptal. |
The CI failures are known unrelated issues. I logged #84323 too for the unknown one. |
@tmds thanks a lot for the help with this issue. |
Fixes #83571.
@stephentoub ptal.