Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce the size of some Http header values #83640

Merged
merged 2 commits into from
Mar 20, 2023
Merged

Reduce the size of some Http header values #83640

merged 2 commits into from
Mar 20, 2023

Conversation

MihaZupan
Copy link
Member

Contributes to #83543

Assuming a 64bit runtime, including the 16 byte object header:

Type Before After
CacheControlHeaderValue 120 80
ContentRangeHeaderValue 72 48
RangeConditionHeaderValue 48 40
RangeItemHeaderValue 48 32
RetryConditionHeaderValue 56 40
StringWithQualityHeaderValue 40 32
WarningHeaderValue 64 56

@MihaZupan MihaZupan added this to the 8.0.0 milestone Mar 18, 2023
@MihaZupan MihaZupan self-assigned this Mar 18, 2023
@ghost
Copy link

ghost commented Mar 18, 2023

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Contributes to #83543

Assuming a 64bit runtime, including the 16 byte object header:

Type Before After
CacheControlHeaderValue 120 80
ContentRangeHeaderValue 72 48
RangeConditionHeaderValue 48 40
RangeItemHeaderValue 48 32
RetryConditionHeaderValue 56 40
StringWithQualityHeaderValue 40 32
WarningHeaderValue 64 56
Author: MihaZupan
Assignees: MihaZupan
Labels:

area-System.Net.Http
Milestone: 8.0.0

@build-analysis build-analysis bot mentioned this pull request Mar 18, 2023
Closed
@build-analysis build-analysis bot mentioned this pull request Mar 20, 2023
Closed
@MihaZupan
Copy link
Member Author

Test failures are known: #83655

@MihaZupan MihaZupan merged commit 1f6fc66 into dotnet:main Mar 20, 2023
@MihaZupan MihaZupan mentioned this pull request Apr 3, 2023
Open
@ghost ghost locked as resolved and limited conversation to collaborators Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub stephentoub approved these changes

Assignees

@MihaZupan MihaZupan

Labels
area-System.Net.Http
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@MihaZupan @stephentoub