Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mono][jit] Add some barriers to the delegate invoke code. #83673

Merged
merged 1 commit into from
Mar 21, 2023
Merged

[mono][jit] Add some barriers to the delegate invoke code. #83673

merged 1 commit into from
Mar 21, 2023

Conversation

vargaz
Copy link
Contributor

@vargaz vargaz commented Mar 20, 2023

Re: #81123.

@ghost ghost assigned vargaz Mar 20, 2023
@lambdageek
Copy link
Member

runtime (Build Libraries Test Run release mono linux arm64 Debug) passed.

Going to trigger the pipeline a couple more times to be sure

@lambdageek
Copy link
Member

/azp run runtime

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lambdageek

This comment was marked as outdated.

Sign in to view
@vargaz vargaz force-pushed the arm64-tramp-wbarrier branch from a1304f9 to cf30f80 Compare March 20, 2023 18:26
@lambdageek
Copy link
Member

arm64 passed Build Libraries Test Run release mono linux arm64 Debug. running again

@lambdageek
Copy link
Member

/azp run runtime

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vargaz vargaz changed the title [mono][jit] Add a read barrier to the arm64 delegate invoke trampoline. [mono][jit] Add some barriers to the delegate invoke code. Mar 20, 2023
@lambdageek
Copy link
Member

/azp run runtime

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lambdageek
Copy link
Member

With read and write barriers, linux-arm64 passed twice. I guess if it passes one more time we should merge it and see if the overall reports in #81123 go down. Thanks for tracking it down @vargaz

This was referenced Mar 21, 2023
Closed
Closed
Closed
@lambdageek
Copy link
Member

/azp run runtime

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@build-analysis build-analysis bot mentioned this pull request Mar 21, 2023
Closed
@vargaz vargaz marked this pull request as ready for review March 21, 2023 18:03
@vargaz vargaz merged commit 7b82cdf into dotnet:main Mar 21, 2023
@vargaz vargaz deleted the arm64-tramp-wbarrier branch March 21, 2023 19:06
@lambdageek lambdageek mentioned this pull request Mar 21, 2023
Closed
@build-analysis build-analysis bot mentioned this pull request Mar 21, 2023
Closed
@kotlarmilos kotlarmilos mentioned this pull request Mar 28, 2023
Closed
@radekdoulik radekdoulik mentioned this pull request Mar 29, 2023
Open
@ghost ghost locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lambdageek lambdageek lambdageek approved these changes

@SamMonoRT SamMonoRT Awaiting requested review from SamMonoRT

Assignees

@vargaz vargaz

Labels
area-Codegen-JIT-mono
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vargaz @lambdageek