Add arm64 wasm support #83677
Add arm64 wasm support #83677
Conversation
eukarpov
requested review from
lambdageek,
vargaz,
SamMonoRT,
thaystg and
marek-safar
as code owners
ghost
added
the
community-contribution
src/mono/mono.proj
Outdated
| @@ -856,7 +856,7 @@ | |||
|
|
|||
| <PropertyGroup> | |||
| <_MonoSkipInitCompiler Condition="'$(RealTargetArchitecture)' != '' and '$(RealTargetArchitecture)' != '$(BuildArchitecture)'">false</_MonoSkipInitCompiler> | |||
| <_MonoAotCrossOffsetsCommand Condition="'$(MonoUseCrossTool)' == 'true'">$(PythonCmd) $(MonoProjectRoot)mono/tools/offsets-tool/offsets-tool.py @(MonoAotCrossOffsetsToolParams, ' ')</_MonoAotCrossOffsetsCommand> | |||
| <_MonoAotCrossOffsetsCommand Condition="'$(MonoUseCrossTool)' == 'true'">python $(MonoProjectRoot)mono/tools/offsets-tool/offsets-tool.py @(MonoAotCrossOffsetsToolParams, ' ')</_MonoAotCrossOffsetsCommand> | |||
There was a problem hiding this comment.
This should still use $(PythonCmd), so that it works on other platforms.
You can change it conditionally to python on win/arm64.
There was a problem hiding this comment.
changed and tested with WASM CI for Arm64
https://github.com/Windows-on-ARM-Experiments/runtime/actions/runs/4798720517
|
The mono changes look ok. |
|
@eukarpov when you have a moment, can you please make the suggested change? @radekdoulik @vargaz if the changes look ok minus the suggested item to review, can you please approve? |
| @@ -293,7 +293,6 @@ | |||
| <_EmccLinkFlags Include="-s EXPORTED_RUNTIME_METHODS=$(_EmccExportedRuntimeMethods)" /> | |||
| <_EmccLinkFlags Include="-s EXPORTED_FUNCTIONS=$(_EmccExportedFunctions)" /> | |||
| <_EmccLinkFlags Include="--source-map-base http://example.com" /> | |||
| <_EmccLinkFlags Include="-s STRICT_JS=1" /> | |||
| <_EmccLinkFlags Include="-s WASM_BIGINT=1" /> | |||
There was a problem hiding this comment.
Yes, it is a fix to resolve issue related to regression in the latest emscripten
There was a problem hiding this comment.
I think that latest emscripten doesn't allow it together with EXPORT_ES6=1 which is fine because that is always strict. I think @radekdoulik mentioned that last week.
@steveisok |
|
@radekdoulik @vargaz can one of you please approve if this is ready? |
ghost
locked as resolved and limited conversation to collaborators
No description provided.