[wasm] Cache files in simple server #83744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves measurements comparison between hosts with different storage speeds. In our case local storage vs NFS storage on the otherwise equal hardware. The cache is filled during initial runs of browser-bench. Also do not prefetch `icudt.dat` as it is not used anymore.
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
kg
approved these changes
Mar 21, 2023
kg
reviewed
Mar 21, 2023
|
Failing build is unrelated. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves measurements comparison between hosts with different storage speeds. In our case local storage vs NFS storage on the otherwise equal hardware.
The cache is filled during initial runs of browser-bench.
Also do not prefetch
icudt.datas it is not used anymore.