Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0-preview3] [browser] partial reversal of PR #82826 #83750

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Mar 21, 2023

Backport of #83637 to release/8.0-preview3

/cc @maraf @pavelsavara

Customer Impact

Revert of making legacy JS interop trimmable. Blazor depends on it and the feature wasn't working correctly without wasm-tools workload.

Testing

Manual

Risk

None

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

@ghost
Copy link

ghost commented Mar 22, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #83637 to release/8.0-preview3

/cc @maraf @pavelsavara

Customer Impact

Testing

Risk

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript

Milestone: -

@maraf
Copy link
Member

maraf commented Mar 22, 2023

Failures are not related.

@maraf maraf force-pushed the backport/pr-83637-to-release/8.0-preview3 branch from dbdf86d to de6fa2c Compare March 22, 2023 10:05
@marek-safar
Copy link
Contributor

@carlossanlop @mmitche please merge before releasing

@carlossanlop
Copy link
Member

@marek-safar @pavelsavara has this been approved by Tactics?

@marek-safar
Copy link
Contributor

@carlossanlop I was under impression we are still in P3 open build window

@mmitche
Copy link
Member

mmitche commented Mar 22, 2023

@leecow Are we doing tactics approval of p3 changes at this point?

@leecow
Copy link
Member

leecow commented Mar 22, 2023

This will need to be approved by Tactics since we've passed code-complete for Preview 3.

@carlossanlop carlossanlop added the Servicing-approved Approved for servicing release label Mar 22, 2023
@carlossanlop carlossanlop added this to the 8.0.0 milestone Mar 22, 2023
@carlossanlop
Copy link
Member

Approved by Tactics via email.

@carlossanlop carlossanlop merged commit 1074e57 into release/8.0-preview3 Mar 22, 2023
@carlossanlop carlossanlop deleted the backport/pr-83637-to-release/8.0-preview3 branch March 22, 2023 23:06
@ghost ghost locked as resolved and limited conversation to collaborators Apr 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants