[wasm] More accurate jiterpreter cfg size estimation; generate smaller dispatch tables #83759
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The monitoring pass's addition of a back branch flag made the cfg size estimation less accurate, so this PR mostly fixes that. There is still a bit of underestimation for a few traces I haven't tracked down but for s.r.t I see it maybe underestimate 5 traces in total out of thousands, and it's not off by too much.
This PR also changes the dispatch table generator to only generate dispatch entries for back branch targets specifically (it used to generate them for all branch targets, which is wasteful and incorrect).
Currently if a trace managed to hit the 4kb limit despite our best efforts, we would try to compile it anyway and then fail, which would eventually cause the jiterpreter to be disabled. This PR adds an explicit check for that and logs a warning instead with the name of the trace, which will avoid scenarios where a whole application falls off a cliff due to a couple bad traces.