[release/6.0] Update dependencies from dotnet/xharness

[dotnet-maestro]

This pull request updates the following dependencies

From https://github.com/dotnet/xharness

• Subscription: e0fabb4f-43ca-46cf-d489-08db2b08e5ae
• Build: 20230313.1
• Date Produced: March 13, 2023 6:05:54 PM UTC
• Commit: 0ff1a841e0a5949428c3868258b14ddcfa0da903
• Branch: refs/heads/main

• Updates:
  • Microsoft.DotNet.XHarness.CLI: from 1.0.0-prerelease.21404.1 to 1.0.0-prerelease.23163.1
  • Microsoft.DotNet.XHarness.TestRunners.Xunit: from 1.0.0-prerelease.21404.1 to 1.0.0-prerelease.23163.1

[carlossanlop]

This PR hit a lot of failures. The known issues were all linked above by the bot.

I did find a new issue. @lewing @steveisok @radical is this issue related to the current PR? If not, let me know and I can open an issue for it.

• Queue: Build Browser wasm Release AllSubsets_Mono

• Job: https://dev.azure.com/dnceng-public/public/_build/results?buildId=220473&view=logs&j=108d2c4a-8a62-5a58-8dad-8e1042acc93c&t=568f884b-cc12-5fd3-e7fe-790b5ac403f4

• Two log files:

  • https://helixre107v0xd1eu3ibi6ka.blob.core.windows.net/dotnet-runtime-refs-pull-83829-merge-c2ded779a4604c80bf/System.Net.Http.Functional.Tests/1/console.64c32be9.log?helixlogtype=result
  • https://helixre107v0xd1eu3ibi6ka.blob.core.windows.net/dotnet-runtime-refs-pull-83829-merge-c2ded779a4604c80bf/System.Net.WebSockets.Client.Tests/1/console.b73c53c7.log?helixlogtype=result

• Callstack:

Starting ChromeDriver 84.0.4147.0 (ff714bcb10c3356b1b1b2819148507a34fa4b1f8-refs/heads/master@{#768968}) on port 37171
Only local connections are allowed.
Please see https://chromedriver.chromium.org/security-considerations for suggestions on keeping ChromeDriver safe.
ChromeDriver was started successfully.
[01:48:39] crit: System.Exception: Can't find type named GenericHandler in /datadisks/disk1/work/BE8E0A9C/p/xharness/RemoteLoopMiddleware/RemoteLoopServer.dll
                    at Microsoft.DotNet.XHarness.CLI.CommandArguments.TypeFromAssemblyArgument`1.GetLoadedTypes()+MoveNext() in /_/src/Microsoft.DotNet.XHarness.CLI/CommandArguments/Arguments/TypeFromAssemblyArgument.cs:line 31
                    at Microsoft.DotNet.XHarness.CLI.Commands.WebServer.TestWebServerOptions.FromArguments(IWebServerArguments arguments) in /_/src/Microsoft.DotNet.XHarness.CLI/Commands/WebServer.cs:line 215
                    at Microsoft.DotNet.XHarness.CLI.Commands.Wasm.WasmBrowserTestRunner.RunTestsWithWebDriver(DriverService driverService, IWebDriver driver) in /_/src/Microsoft.DotNet.XHarness.CLI/Commands/WASM/Browser/WasmBrowserTestRunner.cs:line 63
                    at Microsoft.DotNet.XHarness.CLI.Commands.Wasm.WasmTestBrowserCommand.InvokeInternal(ILogger logger) in /_/src/Microsoft.DotNet.XHarness.CLI/Commands/WASM/Browser/WasmTestBrowserCommand.cs:line 77
                    at Microsoft.DotNet.XHarness.CLI.Commands.XHarnessCommand`1.Invoke(IEnumerable`1 arguments) in /_/src/Microsoft.DotNet.XHarness.CLI/Commands/XHarnessCommand.cs:line 145
XHarness exit code: 71 (GENERAL_FAILURE)

[lewing]

That is a new one to me but this is a huge delta from the previous xharness in 6.0 so I'm not really surprised there are issues?
Commits 241
Files changed 510

[steveisok]

@premun @akoeplinger are there extras in runtime we need to accompany this?

[carlossanlop]

Sorry for the noise. @hoyosjs and I saw a weird behavior in the new label check and were investigating by changing the branch.

[premun]

I don't have much knowledge about the WASM parts of XHarness. I don't think there's anything else needed but also no idea what is this RemoteLoopServer. I believe it's a dynamically loaded DLL that we load via ASP.NET as a middleware or something. So I guess there's a mismatch in what we're loading?

[premun]

Afaik, we don't really need this update for anything worthwhile

[carlossanlop]

Afaik, we don't really need this update for anything worthwhile

@premun Should I turn off the darc subscription and close the PR? Same question for the 7.0 one which also has failures: #83828

[premun]

Yeah, that's probably a good idea

[akoeplinger]

The only thing would be the mlaunch bump in xharness since I believe that was needed for recent Xcode versions.

RemoteLoopServer is coming from the runtime repo, see https://github.com/dotnet/runtime/tree/main/src/libraries/Common/tests/System/Net/Prerequisites/RemoteLoopServer.

We might want to branch xharness as well so we could just cherry-pick fixes like the mlaunch bump.

[premun]

Yeah, branching XHarness is probably the right thing to do. I created dotnet/xharness#1010 and can take care of this

[carlossanlop]

Afaik, we don't really need this update for anything worthwhile

@premun Should I turn off the darc subscription and close the PR? Same question for the 7.0 one which also has failures: #83828

Yeah, that's probably a good idea

Per the conversation above, I have disabled runtime's darc subscriptions to xharness in both 6.0 and 7.0, so we can now close the PR.