Enable CS1591 in System.Formats.Cbor

[carlossanlop]

Partially addresses: #49120

CS1591 is the rule that makes triple slash comments mandatory in public APIs.

It was globally suppressed in Arcade, which wasn't ideal, but we introduced a property in dotnet/arcade#12188 to allow using the rule in specific assemblies.

We enabled the SkipArcadeNoWarnCS1591 property by default in the runtime repo with PR: #79134

And now we can use it in the assembly that can successfully generate its own triple slash xml as source of truth.

I manually tested that the rule works by:

• Building the assembly. It succeeds, all public APIs are documented as expected.
• Removing an existing triple slash line from a public API, then building. It fails with the expected error message.

[ghost]

Tagging subscribers to this area: @dotnet/area-system-security, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Partially addresses: #49120

CS1591 is the rule that makes triple slash comments mandatory in public APIs.

It was globally suppressed in Arcade, which wasn't ideal, but we introduced a property in dotnet/arcade#12188 to allow using the rule in specific assemblies.

We enabled the SkipArcadeNoWarnCS1591 property by default in the runtime repo with PR: #79134

And now we can use it in the assembly that can successfully generate its own triple slash xml as source of truth.

Author:	carlossanlop
Assignees:	-
Labels:	area-System.Security
Milestone:	-

[ghost]

Tagging subscribers to this area: @dotnet/area-system-formats-cbor, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Partially addresses: #49120

CS1591 is the rule that makes triple slash comments mandatory in public APIs.

It was globally suppressed in Arcade, which wasn't ideal, but we introduced a property in dotnet/arcade#12188 to allow using the rule in specific assemblies.

We enabled the SkipArcadeNoWarnCS1591 property by default in the runtime repo with PR: #79134

And now we can use it in the assembly that can successfully generate its own triple slash xml as source of truth.

Author:	carlossanlop
Assignees:	carlossanlop
Labels:	area-System.Formats.Cbor
Milestone:	-

[ViktorHofer]

The SkipArcadeNoWarnCS1591 must be set to true in order for Arcade to not add a NoWarn for 1591: https://github.com/dotnet/arcade/blob/0c2fe2f838e63ad8cd9fb14927547479db9a18f1/src/Microsoft.DotNet.Arcade.Sdk/tools/ProjectDefaults.props#L95

Libraries in dotnet/runtime already set it to true for all projects:

runtime/src/libraries/Directory.Build.props

Line 9 in 967250c

<SkipArcadeNoWarnCS1591>true</SkipArcadeNoWarnCS1591>

Intellisense.targets then adds the actual NoWarn 1591 for all libraries that use the intellisense package xml file:

runtime/eng/intellisense.targets

Line 18 in 967250c

<NoWarn Condition="'$(UseIntellisensePackageDocXmlFile)' == 'true'">$(NoWarn);1591</NoWarn>

[carlossanlop]

Then I think issue #49120 can be closed.