Enable CS1591 in System.Formats.Cbor #83837
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses: #49120
CS1591 is the rule that makes triple slash comments mandatory in public APIs.
It was globally suppressed in Arcade, which wasn't ideal, but we introduced a property in dotnet/arcade#12188 to allow using the rule in specific assemblies.
We enabled the
SkipArcadeNoWarnCS1591
property by default in the runtime repo with PR: #79134And now we can use it in the assembly that can successfully generate its own triple slash xml as source of truth.
I manually tested that the rule works by: